netbox: workaround to allow composible python packageOverrides #223268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
packageOverrides
of python unfortunately does not compose. Sincenetbox
's definition usespackageOverrides
internally, this means something likenetbox.override { python3 = python3.override { packageOverrides { ... }; }; }
won't work as expected, since only the package override defined last is applied.see #44426 for related discussion.
Description of changes
replaces the use of
.override
with.overrideScope
, as suggested in #44426 (comment)(note: there's an alternative solution which also does the trick:
I do not know if there are any advantages or disadvantages to either approach, so I've gone with the one suggested in the above-linked comment)
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)