Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310Packages.pymupdf: fix build on darwin #222573

Merged
merged 1 commit into from
Mar 23, 2023
Merged

python310Packages.pymupdf: fix build on darwin #222573

merged 1 commit into from
Mar 23, 2023

Conversation

wegank
Copy link
Member

@wegank wegank commented Mar 22, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 22, 2023
@wegank
Copy link
Member Author

wegank commented Mar 22, 2023

@ofborg build python310Packages.pymupdf python310Packages.pymupdf.passthru.tests

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 22, 2023
@ofborg ofborg bot requested a review from teto March 22, 2023 17:56
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 22, 2023
@wegank wegank merged commit 165a7c6 into NixOS:master Mar 23, 2023
@wegank wegank deleted the pymupdf-darwin branch March 23, 2023 05:33
@wegank wegank mentioned this pull request Apr 13, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wegank