-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt6.qtbase: add patch to fix handling of variable fonts #222311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Tested with tdesktop
.
For reference, the patch was submitted to the Qt project 5 days ago at https://bugreports.qt.io/browse/QTBUG-111994 by a Fedora contributor. There seems to also be a issue with bold and other non-regular styles, https://bugreports.qt.io/browse/QTBUG-112136, which doesn't yet have a correct patch. |
And this issue only applies the patch to Qt6. Looking at Fedora they are applying this fix to Qt5: https://bugzilla.redhat.com/show_bug.cgi?id=2178389. I guess Qt5 will cause a massive rebuild though so should be a separate PR on staging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Qt isn't really my area of expertise but I don't see anything wrong with including a patch from Fedora.
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)