Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt6.qtbase: add patch to fix handling of variable fonts #222311

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Mar 21, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Mar 21, 2023
Copy link
Contributor

@oxalica oxalica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Tested with tdesktop.

@Mathnerd314
Copy link
Contributor

Mathnerd314 commented Mar 22, 2023

For reference, the patch was submitted to the Qt project 5 days ago at https://bugreports.qt.io/browse/QTBUG-111994 by a Fedora contributor. There seems to also be a issue with bold and other non-regular styles, https://bugreports.qt.io/browse/QTBUG-112136, which doesn't yet have a correct patch.

@Mathnerd314
Copy link
Contributor

And this issue only applies the patch to Qt6. Looking at Fedora they are applying this fix to Qt5: https://bugzilla.redhat.com/show_bug.cgi?id=2178389. I guess Qt5 will cause a massive rebuild though so should be a separate PR on staging.

Copy link
Contributor

@Mathnerd314 Mathnerd314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qt isn't really my area of expertise but I don't see anything wrong with including a patch from Fedora.

@NickCao NickCao merged commit 72a8c49 into NixOS:master Mar 23, 2023
@NickCao NickCao deleted the qt6-vf branch March 23, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants