Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.thinc: fix build #222275

Closed
wants to merge 1 commit into from
Closed

python3.pkgs.thinc: fix build #222275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkgs/development/python-modules/thinc/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ buildPythonPackage rec {
pytestCheckHook
];

postPatch = ''
substituteInPlace setup.cfg --replace "blis>=0.7.8,<0.8.0" "blis"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note you can often use pythonRelaxDepsHook to relax or remove a dependency.

Copy link
Contributor Author

@benxiao benxiao Mar 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcdarwin I tried that. but it doesn't seem to affect setup.cfg. I was looking at the pythoinRelexDepsHook shell script, but its still a mystery what files they will act on. by the way. really appreciate that you review my MRs. thanks.

Copy link
Contributor

@danieldk danieldk Mar 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do this. BLIS 0.9.x is broken and causes segfaults. The upper bound of 0.8.0 is there for a reason.

explosion/thinc#771 (comment)
#207070

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for spotting this. I will close it now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danieldk, shall we revert blis to version 0.7.9, so it is breaking spacy?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I did that before, but a mass-update undid it again. There is a suggestion here:

#218614 (comment)

to prevent that from happening in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#223722

'';

# Add native extensions.
preCheck = ''
export PYTHONPATH=$out/${python.sitePackages}:$PYTHONPATH
Expand Down