teams-for-linux: 1.0.45 -> 1.0.53 #219393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3ed927 to
95ffe74
Compare
95ffe74 to
356785d
Compare
|
I'm just marking darwin broken for now unless someone else figures something out or I get access to the Darwin community builder (nix-community/darwin-build-box#12) and can debug |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
The biggest changes are having macOS support and having a multi-account command-line flag. See all other changes at <IsmaelMartinez/teams-for-linux@v1.0.45...v1.0.52> macOS support is not currently working so it has been marked broken after expanding `meta.platforms`.
92550ec to
fadb7ec
Compare
|
Fixes a known bug (two people verified on the issue thread) and has an approval already, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The biggest changes are having macOS support and having a multi-account command-line flag. Other release notes at https://github.com/ismaelmartinez/teams-for-linux/releases
I added myself as maintainer and am letting OfBorg test to see if it builds on macOS or not (and I'll mark it broken if not)
Versions in-between these were waiting on #214062 but this version works without it again (so some of the drive-by changes were originally related to getting it to work with that)
I also tossed in a fix for notification sounds
Fixes #215593
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)