Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.myst parser 0.19.1 #219173

Closed
wants to merge 299 commits into from
Closed

python3Packages.myst parser 0.19.1 #219173

wants to merge 299 commits into from

Conversation

loicreynier
Copy link
Contributor

@loicreynier loicreynier commented Mar 2, 2023

PR closed due to wrong rebase.

github-actions bot and others added 30 commits February 16, 2023 00:03
strip-nondeterminism: fix binary functioning on darwin
hardening flags: add `FORTIFY_SOURCE=3` support
gpgme: update patch to support Python 3.11
not all linkers have a ld binary in bin

also note the '${ld:-}' which allows users to set the ld path with a env
var

> '${foo:-val}' $foo, or val if unset (or null)
checked with diffoscope+difflog and launching the programs

i have fixed that issue in my other gir PRs
and fix double wrapping

it still fails to launch though but its not a regression

$ ./result/bin/dogtail-logout
Traceback (most recent call last):
  File "/nix/store/az8mw2pmhbwlm08176wd62hn0hfzwv8s-python3.10-dogtail-0.9.11/bin/.dogtail-logout-wrapped", line 8, in <module>
    from dogtail.tree import *
  File "/nix/store/az8mw2pmhbwlm08176wd62hn0hfzwv8s-python3.10-dogtail-0.9.11/lib/python3.10/site-packages/dogtail/tree.py", line 5, in <module>
    from dogtail import predicate
  File "/nix/store/az8mw2pmhbwlm08176wd62hn0hfzwv8s-python3.10-dogtail-0.9.11/lib/python3.10/site-packages/dogtail/predicate.py", line 6, in <module>
    from gi.repository import GLib
ModuleNotFoundError: No module named 'gi'
pygobject3 has to be propagated for the import line in the python file
in bin

$ ./result/bin/curtail
Traceback (most recent call last):
  File "/nix/store/fqjld9nchfwqd9x1pywmjfdsqrk4lxds-curtail-1.3.1/bin/.curtail-wrapped", line 37, in <module>
    import gi
ModuleNotFoundError: No module named 'gi'
luckily the lib output does not contain binaries therefore its safe to
remove it from propagatedBuildInputs
'nix build -f . "wrapGAppsHook.tests"' pass
`env -S` allows one to set more than one argument in a shebang. This
small patch allows the patch-shebangs hook to handle this case
appropriately.
@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: kernel The Linux kernel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml 6.topic: python 6.topic: rust 6.topic: stdenv Standard environment 6.topic: systemd 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 2, 2023
@loicreynier loicreynier closed this Mar 2, 2023
@NixOS NixOS locked and limited conversation to collaborators Mar 2, 2023
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 2, 2023
@loicreynier loicreynier deleted the python3Packages.myst-parser-0.19.1 branch March 2, 2023 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: kernel The Linux kernel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml 6.topic: python 6.topic: rust 6.topic: stdenv Standard environment 6.topic: systemd 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Development

Successfully merging this pull request may close these issues.