Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22.11] python3Packages.apache-airflow: add patch for CVE-2023-22884 #214588

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[22.11] python3Packages.apache-airflow: add patch for CVE-2023-22884 #214588

merged 1 commit into from
Mar 8, 2023

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Feb 4, 2023

Description of changes

https://nvd.nist.gov/vuln/detail/CVE-2023-22884

See #214565 for master.

Have tested this by temporarily enabling the mysql provider's tests (tests/providers/mysql/hooks/test_mysql.py) which all pass for me.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@risicle risicle added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Feb 4, 2023
@alyssais
Copy link
Member

error: undefined variable 'parameterized'

@risicle risicle force-pushed the ris-apache-airflow-CVE-2023-22884-r22.11 branch from c9a0e5f to 7fa3ff5 Compare February 12, 2023 00:31
@risicle
Copy link
Contributor Author

risicle commented Feb 12, 2023

Damn didn't mean to include that - it was part of my temporarily-hack-more-extensive-tests-in testing.

Thanks for the heads-up.

@ofborg ofborg bot requested review from bhipple, gbpdt and ingenieroariel February 12, 2023 01:08
LeSuisse
LeSuisse approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good, nixpkgs-review is happy on x86_64 and the test succeeds.

@LeSuisse LeSuisse merged commit 2cb61e2 into NixOS:release-22.11 Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeSuisse LeSuisse LeSuisse approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@bhipple bhipple Awaiting requested review from bhipple

@gbpdt gbpdt Awaiting requested review from gbpdt

@ingenieroariel ingenieroariel Awaiting requested review from ingenieroariel

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@risicle @alyssais @LeSuisse