haskell.packages.ghc94.X11-xft: extract cabal#8455 workaround into helper function #214446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2023
The current workaround for the regression is propagating the runtime dependency closure (technically only Requires.private in the pkg-config files). This can easily be done automatically by mimicking how e.g. pkgsStatic converts buildInputs to propagatedBuildInputs. This is extracted into a helper function, __CabalEagerPkgConfigWorkaround, which can be applied to any package easily.
53d3453 to
a03bb95
Compare
peti
approved these changes
Feb 4, 2023
…r ghc-9.4.4 See gtk2hs/gtk2hs#323 for details.
The package also need an additional jailbreak due to a strict text bound. gtk2hs/gtk2hs#323 (comment)
a03bb95 to
c1f4ad7
Compare
|
@ofborg build haskell.packages.ghc94.X11-xft haskell.packages.ghc94.pango haskell.packages.ghc94.cairo haskell.packages.ghc94.glib |
|
Wow, nice workaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
See comments / commit messages. Having the function and common location in the file should make the overrides easy to clean up when we have a proper solution.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes