Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goku: 0.5.2 -> 0.6.0, fix deps, add aarch64 #205182

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

gdinh
Copy link
Contributor

@gdinh gdinh commented Dec 8, 2022

Description of changes
  • Version bump
  • Add missing dependency on Joker (program would crash before if Joker was not installed via brew)
  • Add aarch64-specific version
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from nikitavoloboev December 8, 2022 20:43
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 8, 2022
@gdinh
Copy link
Contributor Author

gdinh commented Dec 9, 2022

Seems like directory structures of zips for arm and intel versions are different; just pushed fix.

@ofborg ofborg bot requested a review from nikitavoloboev December 9, 2022 01:54
@tjni
Copy link
Contributor

tjni commented Dec 10, 2022

Because CI is backlogged for aarch64-darwin, I built this locally.

Result of nixpkgs-review pr 205182 run on aarch64-darwin 1

1 package built:
  • goku

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1584

@gdinh gdinh requested a review from SuperSandro2000 January 2, 2023 22:53
@SuperSandro2000 SuperSandro2000 merged commit a9afcd2 into NixOS:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants