Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libical: 3.0.14 -> 3.0.15 #194981

Merged
merged 2 commits into from
Oct 9, 2022
Merged

libical: 3.0.14 -> 3.0.15 #194981

merged 2 commits into from
Oct 9, 2022

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Oct 7, 2022

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/libical/libical/releases.

meta.description for libical is: "An Open Source implementation of the iCalendar protocols"

meta.homepage for libical is: "https://github.com/libical/libical"

meta.changelog for libical is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 3.0.15 with grep in /nix/store/k8gxgcr2rnnl5mwcx96czl7g0ggv0x6b-libical-3.0.15
  • found 3.0.15 in filename of file in /nix/store/k8gxgcr2rnnl5mwcx96czl7g0ggv0x6b-libical-3.0.15

Rebuild report (if merged into master) (click to expand)
4546 total rebuild path(s)

4546 package rebuild(s)

First fifty rebuilds by attrpath
ChowKick
CuboCore.coreaction
CuboCore.corearchiver
CuboCore.corefm
CuboCore.coregarage
CuboCore.corehunt
CuboCore.coreimage
CuboCore.coreinfo
CuboCore.corekeyboard
CuboCore.corepad
CuboCore.corepaint
CuboCore.corepdf
CuboCore.corepins
CuboCore.corerenamer
CuboCore.coreshot
CuboCore.corestats
CuboCore.corestuff
CuboCore.coreterminal
CuboCore.coretime
CuboCore.coretoppings
CuboCore.coreuniverse
CuboCore.libcprime
DisnixWebService
EmptyEpsilon
HentaiAtHome
MIDIVisualizer
PageEdit
R
SDL2
SDL2_gfx
SDL2_image
SDL2_mixer
SDL2_net
SDL2_sound
SDL2_ttf
SDL2_ttf_2_0_15
SDL_audiolib
SDL_compat
SDL_gpu
Sylk
_1oom
_20kly
_7kaa
_90secondportraits
abbaye-des-morts
acoustidFingerprinter
adapta-gtk-theme
adl
aegisub
agi
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/k8gxgcr2rnnl5mwcx96czl7g0ggv0x6b-libical-3.0.15 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A libical https://github.com/r-ryantm/nixpkgs/archive/e903932306865715f0863fd9d5d975e8c9b0cae3.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/k8gxgcr2rnnl5mwcx96czl7g0ggv0x6b-libical-3.0.15
ls -la /nix/store/k8gxgcr2rnnl5mwcx96czl7g0ggv0x6b-libical-3.0.15/bin


Pre-merge build results

NixPkgs review skipped


Maintainer pings

@trofi
Copy link
Contributor

trofi commented Oct 11, 2022

Bisect claims that e903932 libical: 3.0.14 -> 3.0.15 broke building of pkgsi686Linux.libical in staging:

$ nix build --no-link -f. -L pkgsi686Linux.libical
...
libical> 98% tests passed, 1 tests failed out of 55
libical> Total Test time (real) =   4.85 sec
libical> The following tests FAILED:
libical>          1 - regression (Failed)
libical> Errors while running CTest

@vcunat
Copy link
Member

vcunat commented Oct 15, 2022

Notably, this prevents building wine. Full log: https://hydra.nixos.org/log/c4ya8sgc0ynpr3wdrvgzvigl2j2p8b93-libical-3.0.15.drv

@trofi
Copy link
Contributor

trofi commented Oct 15, 2022

I spent some time debugging libical-3.0.15 and I think it's a regression from 3.0.14. Next libical release will fix it, but it has a bunch of fixes (all are related to 64-bit time_t on 32-bit systems). Rolling things back to 3.0.14 (at least for 32-bit targets) are probably the easiest.

@r-burns
Copy link
Contributor

r-burns commented Oct 16, 2022

#196229

@wegank wegank mentioned this pull request Oct 25, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants