Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sord: unstable-2021-01-12 -> 0.16.14 #194796

Merged
merged 1 commit into from
Oct 12, 2022
Merged

sord: unstable-2021-01-12 -> 0.16.14 #194796

merged 1 commit into from
Oct 12, 2022

Conversation

fogti
Copy link
Contributor

@fogti fogti commented Oct 6, 2022

Description of changes

Split from #190218.
sord bump to prevent symbol clashes between zix and sord
https://github.com/drobilla/sord/compare/d2efdb2d026216449599350b55c2c85c0d3efb89..9033613014e7e286147fc35fc3f2020c4c8b150c

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@fogti
Copy link
Contributor Author

fogti commented Oct 6, 2022

(split from the zix PR to speed up the review+merge process, because this gets pretty annoying...)

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 7, 2022
@cole-h
Copy link
Member

cole-h commented Oct 7, 2022

@ofborg build sord

@Mindavi
Copy link
Contributor

Mindavi commented Oct 7, 2022

@ofborg build pkgsCross.aarch64-multiplatform.sord

@fogti
Copy link
Contributor Author

fogti commented Oct 8, 2022

@Mindavi

Cannot nix-instantiate `pkgsCross.aarch64-multiplatform.sord' because:
error: Don't know how to run aarch64-unknown-linux-gnu executables.

@vcunat
Copy link
Member

vcunat commented Oct 12, 2022

I tested with this commit picked onto master.

pkgsCross.aarch64-multiplatform.sord builds for me. I tried to build all reverse dependencies (on x86_64-linux), and there's a single regression:

  • muse fails
    In file included from /build/source/muse3/libs/plugin/plugin_cache_writer.cpp:100:
    /nix/store/x88gdkfb7q91lwii22yjznhjfxapwby2-sord-0.16.14/include/sord-0/sord/sord.h:11:10: fatal error: serd/serd.h: No such file or directory
     11 | #include "serd/serd.h"
        |          ^~~~~~~~~~~~~
    
    

vcunat added a commit that referenced this pull request Oct 12, 2022
@vcunat vcunat merged commit b78bf08 into NixOS:staging Oct 12, 2022
@vcunat
Copy link
Member

vcunat commented Oct 12, 2022

Resolved in e264d5c. I wanted to push it into this PR but I was denied. Anyway, it's all in staging now.

@fogti fogti deleted the sord branch October 12, 2022 21:24
@fogti
Copy link
Contributor Author

fogti commented Oct 12, 2022

Thanks.

@fogti
Copy link
Contributor Author

fogti commented Oct 12, 2022

@vcunat wouldn't it make more sense to put serd into propagatedBuildInputs of sord then?

Oh wait, it already is, do you have any idea why muse doesn't pick that up properly?

@vcunat
Copy link
Member

vcunat commented Oct 12, 2022

I haven't looked into that. Packages often don't use pkg-config ideally, or there could be a bug in some of the .pc files. Or maybe something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants