Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipewire: 0.3.58 -> 0.3.59 #194496

Merged
merged 2 commits into from
Oct 10, 2022
Merged

pipewire: 0.3.58 -> 0.3.59 #194496

merged 2 commits into from
Oct 10, 2022

Conversation

jansol
Copy link
Contributor

@jansol jansol commented Oct 4, 2022

Description of changes

https://gitlab.freedesktop.org/pipewire/pipewire/-/releases/0.3.59

New dependency on google/liblc3 for the new Bluetooth 5 Low Energy audio protocol:
https://github.com/google/liblc3/releases/tag/v1.0.0

Sadly I don't have any new enough headphones to test this part.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@jansol jansol requested a review from K900 October 4, 2022 21:42
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 4, 2022
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 4, 2022
@ofborg ofborg bot requested review from jtojnar and Kranzes October 4, 2022 21:52
K900
K900 approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@K900 K900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, don't have any LC3 hardware to test with.

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 7, 2022
@K900
Copy link
Contributor

K900 commented Oct 8, 2022

Upstream recommended backport: https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/94a64268613adac8ef6f3e6c1f04468220540d00

@jansol jansol removed request for mmahut and ttuegel October 9, 2022 17:18
@jansol jansol removed the request for review from RaghavSood October 9, 2022 17:18
@lovesegfault lovesegfault merged commit f5fb6e5 into NixOS:staging Oct 10, 2022
@jansol jansol deleted the pipewire branch October 10, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault left review comments

@K900 K900 K900 approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@Kranzes Kranzes Awaiting requested review from Kranzes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jansol @K900 @lovesegfault @bobby285271