Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noto-fonts-emoji: 2.034 -> 2.038 [Unicode 15.0] #194105

Merged
merged 2 commits into from
Oct 4, 2022
Merged

noto-fonts-emoji: 2.034 -> 2.038 [Unicode 15.0] #194105

merged 2 commits into from
Oct 4, 2022

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Oct 2, 2022 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

@ofborg build noto-fonts-emoji

@ofborg ofborg bot requested a review from Mathnerd314 October 2, 2022 17:44
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 2, 2022
@sternenseemann
Copy link
Member Author

sternenseemann commented Oct 3, 2022 •
edited
Loading

Tested all reverse deps locally on x86_64-linux, ofborg failures are timeouts:

5 packages built:
deltachat-desktop noto-fonts-emoji python310Packages.nototools python39Packages.nototools twitter-color-emoji

Mathnerd314
Mathnerd314 approved these changes Oct 3, 2022
View reviewed changes
pkgs/data/fonts/noto-fonts/default.nix
mkdir -p $out/share/fonts/noto
cp NotoColorEmoji.ttf fonts/NotoEmoji-Regular.ttf $out/share/fonts/noto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right. There is a new black-and-white emoji font, discussed in googlefonts/noto-emoji#390, but if that gets packaged it should probably be a separate package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know! Would be nice to be able to build that from source then, as well.

@sternenseemann sternenseemann merged commit da60d46 into NixOS:master Oct 4, 2022
@sternenseemann sternenseemann deleted the noto-emoji-unicode-15 branch October 4, 2022 00:11
@sternenseemann
Copy link
Member Author

@Mathnerd314 Is it just me or are the new Unicode 15 emojis like shaking face, pink heart etc. missing despite being present in the source? Wonder what's going wrong there (for me).

@Mathnerd314
Copy link
Contributor

No idea, could be harfbuzz or freetype or something else in the font rendering stack that hasn't updated the database. I update my system like every 6 months so I wouldn't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathnerd314 Mathnerd314 Mathnerd314 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sternenseemann @Mathnerd314