darwin.libtapi: update for cross-compilation #190254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In b060076 ("cc-wrapper: broaden explicit libc++abi linking for LLVM stdenv"), all packages started to be linked with -lc++abi. When cross compiling, the libcxxabi path seemingly needs to be passed to the the libtapi derivation; it won't pick it up on its own (perhaps because of the bootstrapping?).
Mindavi
approved these changes
Sep 19, 2022
|
Is there an easy test case for verifying this from x86_64-darwin? |
I think the most immediate dependency is |
toonn
approved these changes
Sep 25, 2022
|
I accidentally merged this to staging here, 3b8aa21. This means it's gonna be unnecessarily delayed but it'll get to master eventually. Apologies! Still need to figure out a workflow that'll prevent me making mistakes like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
In #181485, all packages started to be linked with
-lc++abi. When cross compiling, the libcxxabi path seemingly needs to be passed to the the libtapi derivation; it won't pick it up on its own (perhaps because of the bootstrapping?).Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes