Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make-bootstrap-tools: add pbzx and tbd tools on x86_64-darwin #181550

Merged

Conversation

reckenrode
Copy link
Contributor

Description of changes

As part of making the 11.0 SDK stdenv bootstrap on x86_64-darwin, I need to add a couple of things that are already in the aarch64-darwin bootstrap-tools. This change adds those. This is for #180931 but separate due to needing the bootstrap-tools.cpio.bz2 to update stdenv per the script laid out in #151399.

I’ve successfully run nix-build pkgs/stdenv/darwin/make-bootstrap-tools.nix -A test on both x86_64-darwin. I also used the bootstrapped tools to build stdenvs for and the packages fixed in #180931.

Sandbox: set to relaxed.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 15, 2022
@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Jul 15, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 15, 2022
@SuperSandro2000
Copy link
Member

I want to express a wish for the future: make the darwin stdenv smaller.

but otherwise sounds LGTM to a none darwin person.

Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need this for the SDK bump too so I think it's fine.
Maybe you can at least cherry pick this commit too? It adds print-reexports to the bootstrap-tools, which I needed to be able to mix and match SDK and source releases.
That way we can avoid bumping the bootstrap-tools just to add another utility.

As for moving this forward, I think we need to have the bootstrap-tools built by Hydra and then someone from the infra team needs to upload them to be hosted on nixos.org. I don't think the Hydra job I have access to builds the bootstrap-tools tarball though.

pkgs/stdenv/darwin/make-bootstrap-tools.nix Show resolved Hide resolved
@reckenrode
Copy link
Contributor Author

I need this for the SDK bump too so I think it's fine. Maybe you can at least cherry pick this commit too? It adds print-reexports to the bootstrap-tools, which I needed to be able to mix and match SDK and source releases. That way we can avoid bumping the bootstrap-tools just to add another utility.

This is done. I’ve cherry-picked that commit. Unfortunately, it looks like the TBD tools are still needed for the 11.0 SDK bootstrap (see my other reply for the specific error message).

@reckenrode
Copy link
Contributor Author

I reverted the PR back to the original commit of just adding pbzx and the TBD tools.

Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, to actually get our new bootstrap-tools we'll have to wait a bit. My question about it in the infra channel sparked finding out the jobs that build it have been disappeared for a while. Attempt to fix it in this PR but it reverts some cross-compilation changes, which is unfortunate : /

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 22, 2022
@SuperSandro2000 SuperSandro2000 merged commit 0e0cc47 into NixOS:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants