-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make-bootstrap-tools: add pbzx and tbd tools on x86_64-darwin #181550
make-bootstrap-tools: add pbzx and tbd tools on x86_64-darwin #181550
Conversation
I want to express a wish for the future: make the darwin stdenv smaller. but otherwise sounds LGTM to a none darwin person. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need this for the SDK bump too so I think it's fine.
Maybe you can at least cherry pick this commit too? It adds print-reexports
to the bootstrap-tools, which I needed to be able to mix and match SDK and source releases.
That way we can avoid bumping the bootstrap-tools just to add another utility.
As for moving this forward, I think we need to have the bootstrap-tools built by Hydra and then someone from the infra team needs to upload them to be hosted on nixos.org. I don't think the Hydra job I have access to builds the bootstrap-tools tarball though.
This is done. I’ve cherry-picked that commit. Unfortunately, it looks like the TBD tools are still needed for the 11.0 SDK bootstrap (see my other reply for the specific error message). |
15eb29f
to
8d1c118
Compare
I reverted the PR back to the original commit of just adding pbzx and the TBD tools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
However, to actually get our new bootstrap-tools we'll have to wait a bit. My question about it in the infra channel sparked finding out the jobs that build it have been disappeared for a while. Attempt to fix it in this PR but it reverts some cross-compilation changes, which is unfortunate : /
Description of changes
As part of making the 11.0 SDK stdenv bootstrap on x86_64-darwin, I need to add a couple of things that are already in the aarch64-darwin bootstrap-tools. This change adds those. This is for #180931 but separate due to needing the bootstrap-tools.cpio.bz2 to update stdenv per the script laid out in #151399.
I’ve successfully run
nix-build pkgs/stdenv/darwin/make-bootstrap-tools.nix -A test
on both x86_64-darwin. I also used the bootstrapped tools to build stdenvs for and the packages fixed in #180931.Sandbox: set to relaxed.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes