Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntl: explicitly set 'configurePlatforms = [ ];' #181061

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jul 11, 2022

Without the change build with config.configurePlatformsByDefault = true
fails as:

$ nix build -f. ntl --arg config '{ configurePlatformsByDefault = true; }' -L
...
Error: unrecognized option: --build=x86_64-unknown-linux-gnu
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Without the change build with config.configurePlatformsByDefault = true
fails as:

    $ nix build -f. ntl --arg config '{ configurePlatformsByDefault = true; }' -L
    ...
    Error: unrecognized option: --build=x86_64-unknown-linux-gnu
Copy link
Member

@collares collares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mindavi Mindavi merged commit 019931c into NixOS:master Jul 12, 2022
@trofi trofi deleted the configurePlatforms-for-ntl branch July 12, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants