Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: update #178520

Merged
merged 3 commits into from
Jun 23, 2022
Merged

vimPlugins: update #178520

merged 3 commits into from
Jun 23, 2022

Conversation

malob
Copy link
Member

@malob malob commented Jun 22, 2022

Description of changes

Update vimPlugins (ran update.py and updated hashes as required in overrides), revert d7bfa0d which causes build issues since #178180 landed, and do a little cleanup in overrides.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

malob added 2 commits June 21, 2022 16:39
This reverts commit d7bfa0d, which
causes build issues since NixOS#178180 was merged.
@malob malob requested a review from jonringer as a code owner June 22, 2022 01:42
@malob malob requested a review from teto June 22, 2022 01:42
@malob malob force-pushed the update-vimPlugins branch from 2f406c5 to d7820aa Compare June 22, 2022 01:44
@malob
Copy link
Member Author

malob commented Jun 22, 2022

Result of nixpkgs-review pr 178520 run on aarch64-darwin 1

8 packages marked as broken and skipped:
  • vimPlugins.The_NERD_tree
  • vimPlugins.cmp-pandoc-nvim
  • vimPlugins.command_T
  • vimPlugins.fugitive
  • vimPlugins.maktaba
  • vimPlugins.rhubarb
  • vimPlugins.snipmate
  • vimPlugins.tlib
180 packages built:
  • spacevim
  • vimPlugins.SchemaStore-nvim
  • vimPlugins.SpaceVim
  • vimPlugins.YouCompleteMe
  • vimPlugins.aerial-nvim
  • vimPlugins.ale
  • vimPlugins.alpha-nvim
  • vimPlugins.asyncrun-vim
  • vimPlugins.aurora
  • vimPlugins.auto-session
  • vimPlugins.barbar-nvim
  • vimPlugins.bufferline-nvim
  • vimPlugins.catppuccin-nvim
  • vimPlugins.catppuccin-vim
  • vimPlugins.chad
  • vimPlugins.cmp-buffer
  • vimPlugins.cmp-clippy
  • vimPlugins.cmp-copilot
  • vimPlugins.cmp-dap
  • vimPlugins.cmp-dictionary
  • vimPlugins.cmp-digraphs
  • vimPlugins.cmp-fish
  • vimPlugins.cmp-fuzzy-buffer
  • vimPlugins.cmp-fuzzy-path
  • vimPlugins.cmp-git
  • vimPlugins.cmp-greek
  • vimPlugins.cmp-latex-symbols
  • vimPlugins.cmp-look
  • vimPlugins.cmp-neosnippet
  • vimPlugins.cmp-npm
  • vimPlugins.cmp-nvim-lsp-signature-help
  • vimPlugins.cmp-nvim-tags
  • vimPlugins.cmp-rg
  • vimPlugins.cmp-snippy
  • vimPlugins.cmp-tmux
  • vimPlugins.cmp-vim-lsp
  • vimPlugins.cmp-vimwiki-tags
  • vimPlugins.cmp-zsh
  • vimPlugins.coc-fzf
  • vimPlugins.coc-lua
  • vimPlugins.coc-nvim
  • vimPlugins.command-t
  • vimPlugins.comment-nvim
  • vimPlugins.completion-treesitter
  • vimPlugins.copilot-vim
  • vimPlugins.coq-artifacts
  • vimPlugins.coq-thirdparty
  • vimPlugins.coq_nvim
  • vimPlugins.dashboard-nvim
  • vimPlugins.diffview-nvim
  • vimPlugins.edge
  • vimPlugins.editorconfig-vim
  • vimPlugins.everforest
  • vimPlugins.fern-vim
  • vimPlugins.ferret
  • vimPlugins.fidget-nvim
  • vimPlugins.flutter-tools-nvim
  • vimPlugins.fuzzy-nvim
  • vimPlugins.fzf-lsp-nvim
  • vimPlugins.fzf-lua
  • vimPlugins.git-blame-nvim
  • vimPlugins.gitsigns-nvim
  • vimPlugins.glow-nvim
  • vimPlugins.gruvbox-material
  • vimPlugins.gruvbox-nvim
  • vimPlugins.gv-vim
  • vimPlugins.hologram-nvim
  • vimPlugins.hop-nvim
  • vimPlugins.hotpot-nvim
  • vimPlugins.impatient-nvim
  • vimPlugins.kanagawa-nvim
  • vimPlugins.lazygit-nvim
  • vimPlugins.lean-nvim
  • vimPlugins.lexima-vim
  • vimPlugins.lf-vim
  • vimPlugins.lightspeed-nvim
  • vimPlugins.litee-filetree-nvim
  • vimPlugins.lsp_signature-nvim
  • vimPlugins.lspcontainers-nvim
  • vimPlugins.lspsaga-nvim
  • vimPlugins.lualine-nvim
  • vimPlugins.luasnip
  • vimPlugins.lush-nvim
  • vimPlugins.material-nvim
  • vimPlugins.mini-nvim
  • vimPlugins.minimap-vim
  • vimPlugins.neogit
  • vimPlugins.neorg
  • vimPlugins.neoscroll-nvim
  • vimPlugins.neovim-ayu
  • vimPlugins.nerdtree
  • vimPlugins.nui-nvim
  • vimPlugins.null-ls-nvim
  • vimPlugins.nvim-autopairs
  • vimPlugins.nvim-bqf
  • vimPlugins.nvim-cmp
  • vimPlugins.nvim-dap
  • vimPlugins.nvim-dap-ui
  • vimPlugins.nvim-gdb
  • vimPlugins.nvim-gps
  • vimPlugins.nvim-hlslens
  • vimPlugins.nvim-jdtls
  • vimPlugins.nvim-lint
  • vimPlugins.nvim-lspconfig
  • vimPlugins.nvim-luapad
  • vimPlugins.nvim-metals
  • vimPlugins.nvim-notify
  • vimPlugins.nvim-snippy
  • vimPlugins.nvim-solarized-lua
  • vimPlugins.nvim-tree-lua
  • vimPlugins.nvim-treesitter
  • vimPlugins.nvim-treesitter-context
  • vimPlugins.nvim-ts-rainbow
  • vimPlugins.octo-nvim
  • vimPlugins.onedark-nvim
  • vimPlugins.onedarkpro-nvim
  • vimPlugins.orgmode
  • vimPlugins.package-info-nvim
  • vimPlugins.purescript-vim
  • vimPlugins.refactoring-nvim
  • vimPlugins.rose-pine
  • vimPlugins.scrollbar-nvim
  • vimPlugins.sonokai
  • vimPlugins.space-vim
  • vimPlugins.spellsitter-nvim
  • vimPlugins.sqlite-lua
  • vimPlugins.sved
  • vimPlugins.tabline-nvim
  • vimPlugins.telescope-cheat-nvim
  • vimPlugins.telescope-frecency-nvim
  • vimPlugins.telescope-fzf-native-nvim
  • vimPlugins.telescope-fzf-writer-nvim
  • vimPlugins.telescope-fzy-native-nvim
  • vimPlugins.telescope-nvim
  • vimPlugins.telescope-project-nvim
  • vimPlugins.telescope-symbols-nvim
  • vimPlugins.telescope-z-nvim
  • vimPlugins.telescope-zoxide
  • vimPlugins.tlib_vim
  • vimPlugins.toggleterm-nvim
  • vimPlugins.vifm-vim
  • vimPlugins.vim-addon-actions
  • vimPlugins.vim-addon-completion
  • vimPlugins.vim-addon-goto-thing-at-cursor
  • vimPlugins.vim-addon-nix
  • vimPlugins.vim-addon-sql
  • vimPlugins.vim-addon-syntax-checker
  • vimPlugins.vim-addon-toggle-buffer
  • vimPlugins.vim-autoformat
  • vimPlugins.vim-bazel
  • vimPlugins.vim-clap
  • vimPlugins.vim-code-dark
  • vimPlugins.vim-codefmt
  • vimPlugins.vim-dadbod
  • vimPlugins.vim-dadbod-completion
  • vimPlugins.vim-dadbod-ui
  • vimPlugins.vim-floaterm
  • vimPlugins.vim-fugitive
  • vimPlugins.vim-git
  • vimPlugins.vim-ledger
  • vimPlugins.vim-lsp
  • vimPlugins.vim-maktaba
  • vimPlugins.vim-markdown-composer
  • vimPlugins.vim-mundo
  • vimPlugins.vim-oscyank
  • vimPlugins.vim-rhubarb
  • vimPlugins.vim-sandwich
  • vimPlugins.vim-slime
  • vimPlugins.vim-smoothie
  • vimPlugins.vim-snipmate
  • vimPlugins.vim-snippets
  • vimPlugins.vim-startuptime
  • vimPlugins.vim-tpipeline
  • vimPlugins.vim-ultest
  • vimPlugins.vim-visual-multi
  • vimPlugins.vim-which-key
  • vimPlugins.vimspector
  • vimPlugins.vimtex
  • vimPlugins.winshift-nvim
  • vimPlugins.xptemplate

@malob
Copy link
Member Author

malob commented Jun 22, 2022

Result of nixpkgs-review pr 178520 run on x86_64-darwin 1

7 packages marked as broken and skipped:
  • vimPlugins.The_NERD_tree
  • vimPlugins.command_T
  • vimPlugins.fugitive
  • vimPlugins.maktaba
  • vimPlugins.rhubarb
  • vimPlugins.snipmate
  • vimPlugins.tlib
181 packages built:
  • spacevim
  • vimPlugins.SchemaStore-nvim
  • vimPlugins.SpaceVim
  • vimPlugins.YouCompleteMe
  • vimPlugins.aerial-nvim
  • vimPlugins.ale
  • vimPlugins.alpha-nvim
  • vimPlugins.asyncrun-vim
  • vimPlugins.aurora
  • vimPlugins.auto-session
  • vimPlugins.barbar-nvim
  • vimPlugins.bufferline-nvim
  • vimPlugins.catppuccin-nvim
  • vimPlugins.catppuccin-vim
  • vimPlugins.chad
  • vimPlugins.cmp-buffer
  • vimPlugins.cmp-clippy
  • vimPlugins.cmp-copilot
  • vimPlugins.cmp-dap
  • vimPlugins.cmp-dictionary
  • vimPlugins.cmp-digraphs
  • vimPlugins.cmp-fish
  • vimPlugins.cmp-fuzzy-buffer
  • vimPlugins.cmp-fuzzy-path
  • vimPlugins.cmp-git
  • vimPlugins.cmp-greek
  • vimPlugins.cmp-latex-symbols
  • vimPlugins.cmp-look
  • vimPlugins.cmp-neosnippet
  • vimPlugins.cmp-npm
  • vimPlugins.cmp-nvim-lsp-signature-help
  • vimPlugins.cmp-nvim-tags
  • vimPlugins.cmp-pandoc-nvim
  • vimPlugins.cmp-rg
  • vimPlugins.cmp-snippy
  • vimPlugins.cmp-tmux
  • vimPlugins.cmp-vim-lsp
  • vimPlugins.cmp-vimwiki-tags
  • vimPlugins.cmp-zsh
  • vimPlugins.coc-fzf
  • vimPlugins.coc-lua
  • vimPlugins.coc-nvim
  • vimPlugins.command-t
  • vimPlugins.comment-nvim
  • vimPlugins.completion-treesitter
  • vimPlugins.copilot-vim
  • vimPlugins.coq-artifacts
  • vimPlugins.coq-thirdparty
  • vimPlugins.coq_nvim
  • vimPlugins.dashboard-nvim
  • vimPlugins.diffview-nvim
  • vimPlugins.edge
  • vimPlugins.editorconfig-vim
  • vimPlugins.everforest
  • vimPlugins.fern-vim
  • vimPlugins.ferret
  • vimPlugins.fidget-nvim
  • vimPlugins.flutter-tools-nvim
  • vimPlugins.fuzzy-nvim
  • vimPlugins.fzf-lsp-nvim
  • vimPlugins.fzf-lua
  • vimPlugins.git-blame-nvim
  • vimPlugins.gitsigns-nvim
  • vimPlugins.glow-nvim
  • vimPlugins.gruvbox-material
  • vimPlugins.gruvbox-nvim
  • vimPlugins.gv-vim
  • vimPlugins.hologram-nvim
  • vimPlugins.hop-nvim
  • vimPlugins.hotpot-nvim
  • vimPlugins.impatient-nvim
  • vimPlugins.kanagawa-nvim
  • vimPlugins.lazygit-nvim
  • vimPlugins.lean-nvim
  • vimPlugins.lexima-vim
  • vimPlugins.lf-vim
  • vimPlugins.lightspeed-nvim
  • vimPlugins.litee-filetree-nvim
  • vimPlugins.lsp_signature-nvim
  • vimPlugins.lspcontainers-nvim
  • vimPlugins.lspsaga-nvim
  • vimPlugins.lualine-nvim
  • vimPlugins.luasnip
  • vimPlugins.lush-nvim
  • vimPlugins.material-nvim
  • vimPlugins.mini-nvim
  • vimPlugins.minimap-vim
  • vimPlugins.neogit
  • vimPlugins.neorg
  • vimPlugins.neoscroll-nvim
  • vimPlugins.neovim-ayu
  • vimPlugins.nerdtree
  • vimPlugins.nui-nvim
  • vimPlugins.null-ls-nvim
  • vimPlugins.nvim-autopairs
  • vimPlugins.nvim-bqf
  • vimPlugins.nvim-cmp
  • vimPlugins.nvim-dap
  • vimPlugins.nvim-dap-ui
  • vimPlugins.nvim-gdb
  • vimPlugins.nvim-gps
  • vimPlugins.nvim-hlslens
  • vimPlugins.nvim-jdtls
  • vimPlugins.nvim-lint
  • vimPlugins.nvim-lspconfig
  • vimPlugins.nvim-luapad
  • vimPlugins.nvim-metals
  • vimPlugins.nvim-notify
  • vimPlugins.nvim-snippy
  • vimPlugins.nvim-solarized-lua
  • vimPlugins.nvim-tree-lua
  • vimPlugins.nvim-treesitter
  • vimPlugins.nvim-treesitter-context
  • vimPlugins.nvim-ts-rainbow
  • vimPlugins.octo-nvim
  • vimPlugins.onedark-nvim
  • vimPlugins.onedarkpro-nvim
  • vimPlugins.orgmode
  • vimPlugins.package-info-nvim
  • vimPlugins.purescript-vim
  • vimPlugins.refactoring-nvim
  • vimPlugins.rose-pine
  • vimPlugins.scrollbar-nvim
  • vimPlugins.sonokai
  • vimPlugins.space-vim
  • vimPlugins.spellsitter-nvim
  • vimPlugins.sqlite-lua
  • vimPlugins.sved
  • vimPlugins.tabline-nvim
  • vimPlugins.telescope-cheat-nvim
  • vimPlugins.telescope-frecency-nvim
  • vimPlugins.telescope-fzf-native-nvim
  • vimPlugins.telescope-fzf-writer-nvim
  • vimPlugins.telescope-fzy-native-nvim
  • vimPlugins.telescope-nvim
  • vimPlugins.telescope-project-nvim
  • vimPlugins.telescope-symbols-nvim
  • vimPlugins.telescope-z-nvim
  • vimPlugins.telescope-zoxide
  • vimPlugins.tlib_vim
  • vimPlugins.toggleterm-nvim
  • vimPlugins.vifm-vim
  • vimPlugins.vim-addon-actions
  • vimPlugins.vim-addon-completion
  • vimPlugins.vim-addon-goto-thing-at-cursor
  • vimPlugins.vim-addon-nix
  • vimPlugins.vim-addon-sql
  • vimPlugins.vim-addon-syntax-checker
  • vimPlugins.vim-addon-toggle-buffer
  • vimPlugins.vim-autoformat
  • vimPlugins.vim-bazel
  • vimPlugins.vim-clap
  • vimPlugins.vim-code-dark
  • vimPlugins.vim-codefmt
  • vimPlugins.vim-dadbod
  • vimPlugins.vim-dadbod-completion
  • vimPlugins.vim-dadbod-ui
  • vimPlugins.vim-floaterm
  • vimPlugins.vim-fugitive
  • vimPlugins.vim-git
  • vimPlugins.vim-ledger
  • vimPlugins.vim-lsp
  • vimPlugins.vim-maktaba
  • vimPlugins.vim-markdown-composer
  • vimPlugins.vim-mundo
  • vimPlugins.vim-oscyank
  • vimPlugins.vim-rhubarb
  • vimPlugins.vim-sandwich
  • vimPlugins.vim-slime
  • vimPlugins.vim-smoothie
  • vimPlugins.vim-snipmate
  • vimPlugins.vim-snippets
  • vimPlugins.vim-startuptime
  • vimPlugins.vim-tpipeline
  • vimPlugins.vim-ultest
  • vimPlugins.vim-visual-multi
  • vimPlugins.vim-which-key
  • vimPlugins.vimspector
  • vimPlugins.vimtex
  • vimPlugins.winshift-nvim
  • vimPlugins.xptemplate

@teto
Copy link
Member

teto commented Jun 22, 2022

why is vimPlugins.fugitive marked as broken ?

@malob
Copy link
Member Author

malob commented Jun 22, 2022

why is vimPlugins.fugitive marked as broken ?

@teto, I'm also confused by this, I think it's a quirk of nixpkgs-review, it's not broken, but for some reason it's skipping them.

I manually tested building all the plugins marked as broken or skipped, and they all build for me without issue except for vimPlugins.cmp-pandoc-nvim on aarch64-darwin (which makes sense since it depends on python3Packages.pyopenssl which is marked as broken on that system).

@malob malob requested a review from teto June 22, 2022 17:33
@teto
Copy link
Member

teto commented Jun 22, 2022

I've rebased atop of a72d781 and I now see the same behavior as you with fugitive marked as broken while it builds just fine.

@teto
Copy link
Member

teto commented Jun 23, 2022

@Mic92 any idea where this could come from ? I checked nixpkgs-review tracker and didn't find any relevant issue. I dont want to open an issue if this something I broke in the vimPlugins. Otherwise I can try looking into it

@teto
Copy link
Member

teto commented Jun 23, 2022

I have a few pending changes for vim, let's merge this.

@teto teto merged commit f9958c6 into NixOS:master Jun 23, 2022
@malob malob deleted the update-vimPlugins branch June 23, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants