Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path to openSUSE certificate store #175925

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

alternateved
Copy link
Contributor

Description of changes

It seems that openSUSE suffers from similar issue as Fedora/RHEL which was fixed with #146545. As could be seen from openSUSE repository of ca-certificates, openSUSE has certificate store in /var/lib/ca-certificates which then gets symlinked to all other places where applications would expect certificate store.

This fixes issue with ERR_CERT_AUTHORITY_INVALID error while trying to use Electron apps such as Discord or Slack.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 16, 2022

Looks good to me. You have to change the target branch to staging, though: this will cause a massive number of rebuilds.

@alternateved alternateved changed the base branch from master to staging June 16, 2022 13:28
@alternateved
Copy link
Contributor Author

Of course, thanks.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 16, 2022

Ah, one last thing: can you prefix the commit message with the name of the package?
Like p11-kit: add path ...

@alternateved alternateved force-pushed the add-opensuse-certificate-store branch from a9f1a19 to d9775e9 Compare June 16, 2022 14:14
@alternateved
Copy link
Contributor Author

Is there anything else that I should correct?

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 22, 2022

No, I simply haven't been checking this PR.
Looks good to go now, thank you.

@rnhmjoj rnhmjoj merged commit 8942163 into NixOS:staging Jun 22, 2022
@alternateved
Copy link
Contributor Author

Great! Thank you for your help and suggestions.

@alternateved alternateved deleted the add-opensuse-certificate-store branch June 22, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants