-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdenv: switch default from gcc10 to gcc11 #174282
stdenv: switch default from gcc10 to gcc11 #174282
Conversation
This will mainly affect ARM which is still using gcc10; x86_64 (darwin and linux), RISC-V (linux), and aarch64 (darwin) are already using gcc11 so this will remove their version override. aarch64 (linux), vc4, and relibc will remain pinned to previous versions due to unresolved issues.
This comment was marked as resolved.
This comment was marked as resolved.
The platforms that changed version would be ARM and i686 (need testing) I tested x86_64 linux and had to rebuild a couple hundred or so packages and stdenv. Would appreciate testing on other platforms like aarch64-linux (gcc9), x86_64-darwin, aarch64-darwin, riscv-linux, etc. |
I don't understand this line. Oh you meant you rebuilt those because you based on staging? (as this commit doesn't switch that) i686-linux couldn't make this recently, but I have a vague memory that the issue has been fixed in the meantime. I'm already rebuilding wine which I used earlier to run into the problem. |
This commit is on top of master (not staging) unsure why I had a stdenv rebuild and a couple hundred rebuilds though. |
No (stdenv) rebuild on x86_64-linux for me (or OfBorg). |
Ah maybe I catched the merge of staging-next into master, its good to know that this doesn't cause a mass-rebuild/stdenv-rebuild. |
That had binaries in cache.nixos.org long before the merge. (except for aarch64-linux) |
If we stay in not red rebuilds we could easily merge this into master if you want. I don't think there is much testing for platforms other the two darwins and linux x86_64 and aarch64 on staging anyway. |
|
Maybe someone from @NixOS/mobile-nixos ? |
boehm-gc tests are broken on armv7l with gcc11: https://gist.github.com/misuzu/46c4eb4387676124054f7e20a252554b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested building nix and git with this change on top of 74a1793 for armv7l-linux, both native & cross.
The issue with boehm-gc is gone now.
Description of changes
This will mainly affect i686 and ARM which is still using gcc10;
x86_64 (darwin and linux), RISC-V (linux), and aarch64 (darwin) are
already using gcc11 so this will remove their version override.
aarch64 (linux), vc4, and relibc will remain pinned to previous versions
due to unresolved issues.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes