Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alliance: 5.0 -> 5.1.1 #17353

Merged
merged 1 commit into from
Jul 30, 2016
Merged

alliance: 5.0 -> 5.1.1 #17353

merged 1 commit into from
Jul 30, 2016

Conversation

RamKromberg
Copy link
Contributor

Motivation for this change

@fpletz noticed it was broken in #17322 so I figured I'd fix it.

Note it's pretty much a complete package rewrite with over 7 years in-between tarballs.

The binaries require about a dozen /etc/ files I didn't feel like writing a module for. So, there's now two scripts: alliance-install and alliance-uninstall to handle their deployment (root required).

The documentations are copied as is into $out/share/alliance instead of being compiled with latex.

xgra (graph viewer) doesn't seem to work. Lessfit complained about deprecated X functions while motif failed silently. The other binaries execute fine.

Finally, I switched from lesstif to motif.

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@RamKromberg, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bjornfor to be a potential reviewer


substituteInPlace sea/src/DEF_grammar_lex.l \
--replace "ifndef FLEX_BETA" "if (YY_FLEX_MAJOR_VERSION <= 2) && (YY_FLEX_MINOR_VERSION < 6)"
./autostuff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indenting slightly off here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

@obadz obadz added 8.has: package (update) This PR updates a package to a newer version 9.needs: clean-up labels Jul 30, 2016
@obadz
Copy link
Contributor

obadz commented Jul 30, 2016

Ok cool

@obadz obadz merged commit 78d82f3 into NixOS:master Jul 30, 2016
@RamKromberg
Copy link
Contributor Author

Thanks! :)

@RamKromberg RamKromberg deleted the fix/alliance branch July 30, 2016 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version 9.needs: clean-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants