Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21.11] matrix-appservice-irc: update matrix-org-irc to 1.2.1 #171510

Merged
merged 2 commits into from
May 4, 2022
Merged

[21.11] matrix-appservice-irc: update matrix-org-irc to 1.2.1 #171510

merged 2 commits into from
May 4, 2022

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented May 4, 2022 •
edited
Loading

https://github.com/matrix-org/node-irc/blob/master/CHANGELOG.md#121-2022-05-04

Description of changes

Patching around the auto-generated node-packages is not ideal, but there were breaking changes since 0.30 in matrix-appservice-irc, so here we go.

Backport test fixes from #171505

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

mweinelt added 2 commits May 4, 2022 10:44
@mweinelt
matrix-appservice-irc: update matrix-org-irc to 1.2.1
65e9232 
https://github.com/matrix-org/node-irc/blob/master/CHANGELOG.md#121-2022-05-04
@mweinelt
nixos/tests/matrix-appservice-irc: disable registration verification
cffe01a 
The test would previously error out like this:

> synapse_homeserver[1155]: synapse.config._base.ConfigError: You have
> enabled open registration without any verification. This is a known
> vector for spam and abuse. If you would like to allow public
> registration, please consider adding email, captcha, or token-based
> verification. Otherwise this check can be removed by setting the
> `enable_registration_without_verification` config option to `true`.

(cherry picked from commit 1d2a0b8)
@mweinelt mweinelt requested a review from jonringer as a code owner May 4, 2022 09:04
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label May 4, 2022
@mweinelt mweinelt added the 1.severity: security Issues which raise a security issue, or PRs that fix one label May 4, 2022
@piegamesde piegamesde merged commit a9aa0fe into NixOS:release-21.11 May 4, 2022
@mweinelt mweinelt deleted the 21.11/matrix-appservice-irc branch May 4, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mweinelt @piegamesde