-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM 10,11,12,13,14: add enableZ3 argument #163314
base: master
Are you sure you want to change the base?
Conversation
This should target staging. Does this make z3 enter the closure of everything by default on darwin (which uses a llvm stdenv) ? |
Yeah afraid this needs to be off by default, because of the bootstrapping situation. |
@Ericson2314, I'll try to add the necessary flags to make z3 cross-compilable. |
@symphorien, I have tried |
@peperunas No this isn't just about cross, but also about native Darwin boostrapping. Please make the new feature off by default, so this is not a mass rebuild. Then we can merge it and separately decide when it is safe to turn on. |
@Ericson2314, done that and I added a TODO to remind us to take care of the edge case later. Let me know if there's anything else I should do and thank you and @symphorien for the review :-) |
@@ -21,6 +22,7 @@ | |||
|| stdenv.isAarch32 # broken for the armv7l builder | |||
) | |||
, enablePolly ? true | |||
, enableZ3 ? false # TODO: if enabled, this flag is not safe to use when cross-compiling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be asserted
Description of changes
Added Z3 to the build inputs of LLVM versions 10-14 when not cross-compiling. Cross compiling needs further CMake variables I have not personally tested hence the test beforehand.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes