-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc: build with jemalloc #152731
rustc: build with jemalloc #152731
Conversation
4950d49
to
c71e11a
Compare
This change should fix intermittent crashes on macOS Monterey. Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
c71e11a
to
2a69902
Compare
The official Rust build uses jemalloc on aarch64-darwin (https://github.com/rust-lang/rust/blob/acbe4443cc4c9695c0b74a7b64b60333c990a400/src/ci/github-actions/ci.yml#L456). I am a little concerned by nixpkgs still not using jemalloc on aarch64-darwin. |
We could also switch on aarch64 as well. |
rustc: build with jemalloc
rustc: build with jemalloc
rustc: build with jemalloc
rustc: build with jemalloc
rustc: build with jemalloc
rustc: build with jemalloc
Motivation for this change
I have to run
cargo build
several times to build something on macOS,rustc
randomly fails withSIGABRT
.This change fixes the issue for me.
Closes #144704
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes