Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-providers: Update alicloud to v1.144.0 #147225

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

azuwis
Copy link
Contributor

@azuwis azuwis commented Nov 24, 2021

The alicloud provider move from to aliyun/alicloud, update to the latest
version.

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 24, 2021

Result of nixpkgs-review pr 147225 run on x86_64-linux 1

1 package marked as broken and skipped:
  • terraform-full
1 package failed to build:
  • terraform-providers.alicloud

@Mic92
Copy link
Member

Mic92 commented Nov 24, 2021

I am getting:

nix-build '/nix/store/z92gcdnr3g9wgvdv459mk76ry3ywprl1-terraform-provider-alicloud-1.144.0.drv'
this derivation will be built:
  /nix/store/z92gcdnr3g9wgvdv459mk76ry3ywprl1-terraform-provider-alicloud-1.144.0.drv
building '/nix/store/z92gcdnr3g9wgvdv459mk76ry3ywprl1-terraform-provider-alicloud-1.144.0.drv' on 'ssh-ng://nix@graham.r'...
copying 0 paths...
building '/nix/store/z92gcdnr3g9wgvdv459mk76ry3ywprl1-terraform-provider-alicloud-1.144.0.drv'...
unpacking sources
unpacking source archive /nix/store/58hjmd9flaq2qwql48a0gjzxar92pj70-source
source root is source
patching sources
configuring
building
Building subPackage ./.
vendor/k8s.io/client-go/discovery/discovery_client.go:30:2: cannot find package "." in:
        /build/source/vendor/github.com/googleapis/gnostic/openapiv2

@azuwis
Copy link
Contributor Author

azuwis commented Nov 24, 2021

Maybe related kubernetes/client-go#741

I'm on Darwin, and the filesystem is not case sensitive, so I don't get this error.

Do you have any idea how to fix this?

@Mic92
Copy link
Member

Mic92 commented Nov 24, 2021

One could apply patches to update the go mod file?

patches = args.patches or [];

I don't know if proxyVendor is affected by this: https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/go.section.md#go-modules-ssec-language-go

@azuwis azuwis force-pushed the terraform-provider-alicloud branch from f6590a2 to 3641cba Compare November 24, 2021 13:25
The alicloud provider move from to aliyun/alicloud, update to the latest
version.

Also introduct `deleteVendor` in `buildWithGoModule`, the vendor of
alicloud needs to be cleared due to openapiv2 API rename, or the
following error appears when building in case sensitive filesystems:

```
vendor/k8s.io/client-go/discovery/discovery_client.go:30:2: cannot find package "." in:
        /build/source/vendor/github.com/googleapis/gnostic/openapiv2
```
@azuwis azuwis force-pushed the terraform-provider-alicloud branch from 3641cba to 40915ab Compare November 24, 2021 13:28
@azuwis
Copy link
Contributor Author

azuwis commented Nov 24, 2021

Please review the new changes.

@ofborg ofborg bot requested a review from kalbasit November 24, 2021 13:40
@azuwis azuwis requested a review from Mic92 November 24, 2021 13:50
@Mic92 Mic92 merged commit fbd3a42 into NixOS:master Nov 24, 2021
@azuwis azuwis deleted the terraform-provider-alicloud branch November 26, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants