Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel_4: Fix Bazel-built protoc segfault on macOS Monterey #147097

Merged
merged 1 commit into from
Nov 24, 2021
Merged

bazel_4: Fix Bazel-built protoc segfault on macOS Monterey #147097

merged 1 commit into from
Nov 24, 2021

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Nov 23, 2021 •
edited
Loading

Motivation for this change

This was fixed by enabling the user_link_flags_feature for macosx cc_toolchain_config.

References:

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

cc @Profpatsch @uri-canva @SuperSandro2000

@kalbasit kalbasit requested a review from Profpatsch as a code owner November 23, 2021 07:03
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 23, 2021
@kalbasit kalbasit mentioned this pull request Nov 23, 2021
Closed
@ofborg ofborg bot requested a review from mboes November 23, 2021 07:16
@kalbasit
bazel_4: Fix Bazel-built protoc segfault on macOS Monterey
dc8d4f3 
This was fixed by enabling the user_link_flags_feature for macosx cc_toolchain_config.

References:
- bazelbuild/bazel#14216
- bazelbuild/bazel#14275
@kalbasit kalbasit force-pushed the bazel_4_fix_on_macos_monterey branch from b474a18 to dc8d4f3 Compare November 23, 2021 23:09
@uri-canva
Copy link
Contributor

Change looks good, let's wait for ofborg results, I will also test it locally on Monterey.

@uri-canva
Copy link
Contributor

Tested locally on both x86_64-darwin and aarch64-darwin both running Monterey.

@kalbasit
Copy link
Member Author

I'll merge it then, thank you @uri-canva.

@kalbasit kalbasit merged commit c691e08 into NixOS:master Nov 24, 2021
@kalbasit kalbasit deleted the bazel_4_fix_on_macos_monterey branch November 24, 2021 18:55
@github-actions github-actions bot mentioned this pull request Nov 24, 2021
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #147283 for release-21.05.

@github-actions github-actions bot mentioned this pull request Nov 24, 2021
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #147284 for release-21.11.

mkg20001 pushed a commit to mkg20001/nixpkgs that referenced this pull request Nov 29, 2021
@kalbasit @mkg20001
bazel_4: Fix Bazel-built protoc segfault on macOS Monterey (NixOS#147097
94ae231 
)

This was fixed by enabling the user_link_flags_feature for macosx cc_toolchain_config.

References:
- bazelbuild/bazel#14216
- bazelbuild/bazel#14275
@nicu-da nicu-da mentioned this pull request Nov 30, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uri-canva uri-canva uri-canva approved these changes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@mboes mboes Awaiting requested review from mboes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalbasit @uri-canva