Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: 94.0 -> 94.0.1 #145005

Merged
merged 1 commit into from
Nov 7, 2021
Merged

firefox: 94.0 -> 94.0.1 #145005

merged 1 commit into from
Nov 7, 2021

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 7, 2021

Motivation for this change

https://www.mozilla.org/en-US/firefox/94.0.1/releasenotes/

Fixed browser hangs when viewing fullscreen videos on macOS 10.12 (bug 1737998)

shrug

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edolstra and lovesegfault November 7, 2021 20:12
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 7, 2021
@dasJ dasJ merged commit 3ef9b92 into NixOS:master Nov 7, 2021
@mweinelt
Copy link
Member Author

mweinelt commented Nov 7, 2021

Tested on x86_64/sway/pipewire. LGTM.

@mweinelt mweinelt deleted the firefox branch November 7, 2021 21:02
@SebTM
Copy link
Contributor

SebTM commented Nov 17, 2021

Hey @mweinelt,

after the update I have a strange issue when using firefox-package from unstable: When connected to a Bluetooth device and using e.g. YouTube the tab would crash within the first minute. I tried to use firefox-bin with crash-reporter to get further details, but the package still uses 94.0 which is not affected from my tests. Even running firefox from terminal does not show more related information's.

I also tried the "firefox-beta-bin" and the problem seems to not happen there too. I'm using XServer with LightDM, i3wm and pluse-audio.

Relevant config:

hardware.bluetooth.package = pkgs.bluezFull;
hardware.pulseaudio = {
  enable = true;

  /**
   * Bluetooth-Module not needed anymore!
   *
   * @see
   * https://github.com/EHfive/pulseaudio-modules-bt/issues/154
   * https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/440
   * https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/476
  */
  extraModules = [];
  # Use full build here for package with bluetooth support
  package = pkgs.pulseaudioFull;
  support32Bit = true;
};
sound.enable = true;

Do you have an idea?

@mohe2015
Copy link
Contributor

@SebTM This is tracked in #146382

@SebTM
Copy link
Contributor

SebTM commented Nov 17, 2021

@mohe2015 Thanks, haven't found it before 👍🏻

@mweinelt
Copy link
Member Author

FWIW: The issue didn't exist when this upgrade was merged.

@github-actions
Copy link
Contributor

Backport failed for release-21.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-21.05
git worktree add -d .worktree/backport-145005-to-release-21.05 origin/release-21.05
cd .worktree/backport-145005-to-release-21.05
git checkout -b backport-145005-to-release-21.05
ancref=$(git merge-base ccd6afddbe1c903fab546b5ae35e135dcc33b48e 8f499b97ad9c9d7fad6423fa4d334db11a860494)
git cherry-pick -x $ancref..8f499b97ad9c9d7fad6423fa4d334db11a860494

@mweinelt mweinelt added 8.has: port to stable A PR already has a backport to the stable release. and removed backport release-21.05 labels Nov 21, 2021
@mweinelt
Copy link
Member Author

Firefox releases currently cannot be backported automatically, because of conflicts in the wrapper that have not been backported. This will hopefully improve with the 21.11 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants