Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpfs: fix build #144755

Merged
merged 1 commit into from
Nov 5, 2021
Merged

unpfs: fix build #144755

merged 1 commit into from
Nov 5, 2021

Conversation

mdevlamynck
Copy link
Contributor

Fix build by updating to the most recent revision.

ZHF: #144627
@NixOS/nixos-release-managers

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c November 5, 2021 15:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 5, 2021
@mattmelling
Copy link
Contributor

Result of nixpkgs-review pr 144755 run on x86_64-linux 1

1 package built:
  • unpfs

@Artturin
Copy link
Member

Artturin commented Nov 5, 2021

Please update the version and follow https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md

@7c6f434c
Copy link
Member

7c6f434c commented Nov 5, 2021

@ofborg build unpfs

@7c6f434c
Copy link
Member

7c6f434c commented Nov 5, 2021

Looks like we have a fixed-output hash mismatch problem here?

@mdevlamynck
Copy link
Contributor Author

mdevlamynck commented Nov 5, 2021 •
edited
Loading

Does the cargoSha256 include the package version? That's the only change I made. If so I'll update it but I would like to be sure.

Edit: After a quick test It seems to be the case, I'm updating the PR.

@mdevlamynck
unpfs: unstable-2019-05-17 -> unstable-2021-05-23
39ce7a8 
Fix build by updating to the most recent revision
thiagokokada
thiagokokada approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 144755 run on x86_64-linux 1

1 package built:
  • unpfs

@thiagokokada thiagokokada merged commit 505caf2 into NixOS:master Nov 5, 2021
@mdevlamynck mdevlamynck deleted the fix-unpfs branch November 6, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@mattmelling mattmelling mattmelling approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mdevlamynck @mattmelling @Artturin @7c6f434c @thiagokokada