Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: automatically add testVersion where possible #144503

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

treewide: automatically add testVersion where possible #144503

wants to merge 2 commits into from

Conversation

Synthetica9
Copy link
Member

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Synthetica9 Synthetica9 changed the title Test versions treewide: automatically add testVersion where possible Nov 3, 2021
@github-actions github-actions bot added 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: ocaml 6.topic: TeX Issues regarding texlive and TeX in general labels Nov 3, 2021
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 3, 2021
@Synthetica9 Synthetica9 marked this pull request as ready for review November 4, 2021 13:48
@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 11, 2021
SuperSandro2000
SuperSandro2000 requested changes Nov 11, 2021
View reviewed changes
@github-actions github-actions bot removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: erlang 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: ocaml labels Nov 22, 2021
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 22, 2021
@github-actions github-actions bot added 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: ocaml 6.topic: TeX Issues regarding texlive and TeX in general labels Nov 22, 2021
@github-actions github-actions bot removed 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: ocaml 6.topic: TeX Issues regarding texlive and TeX in general labels Nov 22, 2021
@github-actions github-actions bot removed 6.topic: vim 6.topic: ocaml 6.topic: python 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: GNOME GNOME desktop environment and its underlying platform labels Dec 30, 2021
@github-actions github-actions bot added 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: ocaml 6.topic: printing 6.topic: python 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim labels Dec 30, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 30, 2021
@Synthetica9
Copy link
Member Author

Gonna wait for #119942 to merge before continuing this

@superherointj
Copy link
Contributor

Gonna wait for #119942 to merge before continuing this

#119942 is merged. News?

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 7, 2023
@Et7f3
Copy link
Contributor

Et7f3 commented Jan 30, 2023

Can't this be done inside stdenv.mkDerivation ? so other stdenv also get this feature and it avoid boilerplate.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 30, 2023
@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@jonringer jonringer Awaiting requested review from jonringer

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: ocaml 6.topic: printing 6.topic: python 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Synthetica9 @FRidh @superherointj @Et7f3 @SuperSandro2000 @wegank