Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calls: 0.3.1 -> 41.1 #136537

Merged
merged 1 commit into from
Jan 12, 2022
Merged

calls: 0.3.1 -> 41.1 #136537

merged 1 commit into from
Jan 12, 2022

Conversation

tomfitzhenry
Copy link
Contributor

@tomfitzhenry tomfitzhenry commented Sep 3, 2021 •
edited
Loading

Motivation for this change

https://gitlab.gnome.org/GNOME/calls/-/tags/41.1

Currently running on my Pinephone.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tomfitzhenry tomfitzhenry marked this pull request as draft September 3, 2021 02:12
@tomfitzhenry tomfitzhenry changed the title calls: 0.3.1 -> 41.rc calls: 0.3.1 -> 41 Sep 3, 2021
@ofborg ofborg bot requested review from craigem and lheckemann September 3, 2021 02:17
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 3, 2021
@tomfitzhenry tomfitzhenry changed the title calls: 0.3.1 -> 41 calls: 0.3.1 -> 41.0 Sep 19, 2021
@tomfitzhenry tomfitzhenry marked this pull request as ready for review November 7, 2021 13:18
@tomfitzhenry tomfitzhenry requested a review from Mindavi November 7, 2021 13:18
@tomfitzhenry tomfitzhenry changed the title calls: 0.3.1 -> 41.0 calls: 0.3.1 -> 41.1 Nov 7, 2021
@Mindavi
Copy link
Contributor

Mindavi commented Nov 7, 2021 •
edited
Loading

Didn't try on pinephone yet, but at least it builds and runs for x86-64.

My terminal is absolutely getting spammed with this message:

22:53:53.6067 dconf[147558]: WARNING: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

Not sure why that's happening, but maybe something needs to be done about that?

Edit: tried on my pinephone with #121345. It looks kinda weird, but it does run ok. Haven't tried actually calling (yet).

@tomfitzhenry tomfitzhenry mentioned this pull request Dec 10, 2021
Merged
13 tasks
@jtojnar jtojnar mentioned this pull request Dec 16, 2021
Closed
2 tasks
@tomfitzhenry
Copy link
Contributor Author

tomfitzhenry commented Jan 7, 2022 •
edited
Loading

My terminal is absolutely getting spammed with this message:

22:53:53.6067 dconf[147558]: WARNING: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

I do not see that on x86-64 or my Pinephone.

Are you using programs.calls.enable = true;? That sets up the needed dbus service packages.

@jtojnar
Copy link
Member

jtojnar commented Jan 7, 2022

For GNOME apps you need programs.dconf.enable = true;.

@lheckemann
Copy link
Member

programs.calls.enable should probably enable programs.dconf.enable by default, or error or at least warn if it isn't set.

@Mindavi
Copy link
Contributor

Mindavi commented Jan 11, 2022

Ah no, I was probably not using that. So that may have been the issue.

@SuperSandro2000 SuperSandro2000 merged commit 830ea4c into NixOS:master Jan 12, 2022
@SuperSandro2000
Copy link
Member

programs.calls.enable should probably enable programs.dconf.enable by default, or error or at least warn if it isn't set.

Can someone please fix this?

tomfitzhenry added a commit to tomfitzhenry/nixpkgs that referenced this pull request Jan 14, 2022
@tomfitzhenry
programs/calls: enable dconf
7b21544 
GNOME Calls relies on dconf. Evidence supporting this claim:
https://packages.debian.org/sid/gnome-calls depends on
dconf-gsettings-backend.

Discussed in
NixOS#136537 (comment) :
@tomfitzhenry tomfitzhenry mentioned this pull request Jan 14, 2022
Merged
13 tasks
@tomfitzhenry
Copy link
Contributor Author

programs.calls.enable should probably enable programs.dconf.enable by default, or error or at least warn if it isn't set.

Can someone please fix this?

Done. #155028

@tomfitzhenry tomfitzhenry deleted the calls-41 branch January 14, 2022 19:21
jtojnar pushed a commit that referenced this pull request Feb 7, 2022
@tomfitzhenry @jtojnar
programs/calls: enable dconf
2211a7c 
GNOME Calls relies on dconf. Evidence supporting this claim:
https://packages.debian.org/sid/gnome-calls depends on
dconf-gsettings-backend.

Discussed in
#136537 (comment) :
@tomfitzhenry tomfitzhenry mentioned this pull request Feb 13, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigem craigem Awaiting requested review from craigem

@lheckemann lheckemann Awaiting requested review from lheckemann

@Mindavi Mindavi Awaiting requested review from Mindavi

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomfitzhenry @Mindavi @jtojnar @lheckemann @SuperSandro2000