Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update.py: fix vim's updater script #133832

Merged
merged 1 commit into from
Aug 13, 2021
Merged

update.py: fix vim's updater script #133832

merged 1 commit into from
Aug 13, 2021

Conversation

teto
Copy link
Member

@teto teto commented Aug 13, 2021

recent updates to luarocks updater had broken the vim plugin update script.

Thanks @figsoda for reporting.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@teto teto requested a review from figsoda August 13, 2021 22:08
update.py: fix vim's updater script
7344a0e 
recent updates to luarocks updater had broken the vim plugin update script
@teto teto force-pushed the fix-vim-plugin-updater branch from 271644b to 7344a0e Compare August 13, 2021 22:08
@teto teto mentioned this pull request Aug 13, 2021
Merged
11 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 13, 2021
figsoda
figsoda approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@figsoda figsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, thanks!

@lovesegfault lovesegfault merged commit d0ef271 into NixOS:master Aug 13, 2021
@teto teto deleted the fix-vim-plugin-updater branch August 14, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figsoda figsoda figsoda approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teto @figsoda @lovesegfault