-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Luarocks pyupdater #132473
Luarocks pyupdater #132473
Conversation
177c1ea
to
0242fdf
Compare
0242fdf
to
a0987cd
Compare
0841815
to
4e1423f
Compare
the global lua update had broken several packages, I've pinned versions to keep nixpkgs-review happy |
I've added more changes on a separate branch teto#4 |
Kinda excited to use an unified interface to update different ecosystems. I will follow up with PRs if this gets merged but I dont want to merge it without the approval of any of the other persons using the update.py |
Trying to reuse the update scripts used by kakoune/vim to provide the user with an unified convergence. Some stuff doesn't work yet (parallel download, caching) but I (anyone else welcome to try too) will improve it in other PRs.
mentions lua 5.4 + fixed an error
Several updates
4e1423f
to
b02c265
Compare
I've tested and vim update.py as well as luarocks updater work fine. I will merge and open another PR to improve the interface. |
wip follow up of #133296 |
I didn't / don't have the spare capacity to review this right now, but thank you for working on it. The lua neovim plugin ecosystem seems to be growing fast. |
I am working to improve luarocks2nix to better handle bare git repos so that the vim-plugin infra can handle lua plugin betters (for neovim). Right now lua plugins work but they have to be uploaded to luarocks.org and I dont expect vim plugin authors to do that, hence my changes. |
I see. Thanks again for pushing this forward :) |
Motivation for this change
I wanted to improve (mostly speed it up) the luarocks updater since I intend to run it more frequently. While this is not the case yet, I converted the shellscript to a python script reusing the kakoune/vim plugin infrastructure. Providing the user with an unifed interface across different ecosystems sound like a good idea where applicable.
I dont say my changes are elegant, I strived to minimize the changes in pluginupdate.py to get some feedback first. I believe a sounder OOP approach can be taken in subsequent steps.
cc @Flakebi
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)