Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luarocks pyupdater #132473

Merged
merged 3 commits into from
Aug 9, 2021
Merged

Luarocks pyupdater #132473

merged 3 commits into from
Aug 9, 2021

Conversation

teto
Copy link
Member

@teto teto commented Aug 2, 2021

Motivation for this change

I wanted to improve (mostly speed it up) the luarocks updater since I intend to run it more frequently. While this is not the case yet, I converted the shellscript to a python script reusing the kakoune/vim plugin infrastructure. Providing the user with an unifed interface across different ecosystems sound like a good idea where applicable.

I dont say my changes are elegant, I strived to minimize the changes in pluginupdate.py to get some feedback first. I believe a sounder OOP approach can be taken in subsequent steps.

cc @Flakebi

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: lua 6.topic: vim 8.has: documentation This PR adds or changes documentation labels Aug 2, 2021
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 2, 2021
@teto teto force-pushed the luarocks-pyupdater branch from 177c1ea to 0242fdf Compare August 2, 2021 23:24
@teto teto requested a review from jonringer as a code owner August 2, 2021 23:24
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 2, 2021
@teto teto force-pushed the luarocks-pyupdater branch from 0242fdf to a0987cd Compare August 3, 2021 16:27
@teto
Copy link
Member Author

teto commented Aug 5, 2021

cc @timokau @Mic92 since you've worked the most on this part. I would like to rename the Editor class to something more generic too like EcosystemUpdater/LanguageUpdater.

@teto teto force-pushed the luarocks-pyupdater branch from 0841815 to 4e1423f Compare August 5, 2021 18:30
@teto
Copy link
Member Author

teto commented Aug 5, 2021

the global lua update had broken several packages, I've pinned versions to keep nixpkgs-review happy

@teto
Copy link
Member Author

teto commented Aug 6, 2021

I've added more changes on a separate branch teto#4

@teto
Copy link
Member Author

teto commented Aug 8, 2021

Kinda excited to use an unified interface to update different ecosystems. I will follow up with PRs if this gets merged but I dont want to merge it without the approval of any of the other persons using the update.py

Matthieu Coudron added 3 commits August 9, 2021 21:37
Trying to reuse the update scripts used by kakoune/vim to provide the
user with an unified convergence. Some stuff doesn't work yet (parallel
download, caching) but I (anyone else welcome to try too) will improve
it in other PRs.
mentions lua 5.4 + fixed an error
Several updates
@teto teto force-pushed the luarocks-pyupdater branch from 4e1423f to b02c265 Compare August 9, 2021 19:38
@teto
Copy link
Member Author

teto commented Aug 9, 2021

I've tested and vim update.py as well as luarocks updater work fine. I will merge and open another PR to improve the interface.

@teto teto merged commit 9578494 into NixOS:master Aug 9, 2021
@teto
Copy link
Member Author

teto commented Aug 9, 2021

wip follow up of #133296

@timokau
Copy link
Member

timokau commented Aug 12, 2021

I didn't / don't have the spare capacity to review this right now, but thank you for working on it. The lua neovim plugin ecosystem seems to be growing fast.

@teto
Copy link
Member Author

teto commented Aug 12, 2021

I am working to improve luarocks2nix to better handle bare git repos so that the vim-plugin infra can handle lua plugin betters (for neovim). Right now lua plugins work but they have to be uploaded to luarocks.org and I dont expect vim plugin authors to do that, hence my changes.

@timokau
Copy link
Member

timokau commented Aug 12, 2021

I see. Thanks again for pushing this forward :)

@teto teto deleted the luarocks-pyupdater branch December 31, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants