hyperspace-cli: init at 1.5.1 #130063

MatthewCroughan · 2021-07-13T02:15:30Z

Motivation for this change

Adds the CLI component of Hypercore, previously known as dat https://github.com/hypercore-protocol/cli

Things done

r-rmcgibbo · 2021-07-13T02:54:57Z

Result of nixpkgs-review pr 130063 at 6891ec11 run on aarch64-linux 1

7 packages failed to build:

1 package skipped due to time constraints:

lumo

11 packages built successfully:

parity-ui
python38Packages.batchspawner
python38Packages.dockerspawner
python38Packages.jupyterhub
python38Packages.jupyterhub-ldapauthenticator
python38Packages.jupyterhub-systemdspawner
python38Packages.jupyterhub-tmpauthenticator
python38Packages.oauthenticator
teleprompter
vscode-extensions.matklad.rust-analyzer
vscode-extensions.vadimcn.vscode-lldb

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 130063 at 6891ec11 run on x86_64-linux 1

7 packages failed to build:

1 package skipped due to time constraints:

lumo

35 packages built successfully:

balanceofsatoshis
bitwarden-cli
castnow
create-cycle-app
epgstation
hyperspace-cli
joplin
mirakurun
netlify-cli
parity-ui
pulp
pyright
python38Packages.batchspawner
python38Packages.dockerspawner
python38Packages.jupyterhub
python38Packages.jupyterhub-ldapauthenticator
python38Packages.jupyterhub-systemdspawner
python38Packages.jupyterhub-tmpauthenticator
python38Packages.oauthenticator
redoc-cli
slack
teams
teleprompter
thelounge
timedoctor
vimPlugins.coc-clangd
vimPlugins.coc-explorer
vimPlugins.coc-metals
vimPlugins.coc-prettier
vimPlugins.coc-pyright
vimPlugins.coc-rust-analyzer
vimPlugins.coc-stylelint
vscode-extensions.matklad.rust-analyzer
vscode-extensions.ms-python.vscode-pylance
vscode-extensions.vadimcn.vscode-lldb

39 suggestions:

warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:66207:5:
```
      |
66207 |     version = "1.17.1";
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:69006:5:
```
      |
69006 |     version = "10.6.1";
      |     ^
```
warning: build-tools-in-build-inputs
nodePackages.node-pre-gyp is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/node-packages/node-env.nix:401:7:
```
    |
401 |       buildInputs = [ tarWrapper python nodejs ]
    |       ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:69727:5:
```
      |
69727 |     meta = {
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:103174:5:
```
       |
103174 |     version = "15.0.0";
       |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:103505:5:
```
       |
103505 |     version = "1.1.156";
       |     ^
```
warning: build-tools-in-build-inputs
automake is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/node-packages/node-env.nix:401:7:
```
    |
401 |       buildInputs = [ tarWrapper python nodejs ]
    |       ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:103427:5:
```
       |
103427 |     meta = {
       |     ^
```
warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.

Near pkgs/development/node-packages/node-env.nix:409:14:
```
    |
409 |       inherit dontNpmInstall preRebuild unpackPhase buildPhase;
    |              ^
```

warning: unused-argument

Unused argument: lib.
Near pkgs/development/node-packages/node-packages.nix:3:54:

  |
3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
  |                                                      ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall.

Near pkgs/development/node-packages/node-env.nix:416:7:
```
    |
416 |       installPhase = ''
    |       ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:95462:5:
```
      |
95462 |     version = "3.6.0";
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:105764:5:
```
       |
105764 |     version = "0.12.1";
       |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:103511:5:
```
       |
103511 |     meta = {
       |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:106077:5:
```
       |
106077 |     meta = {
       |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:71123:5:
```
      |
71123 |     meta = {
      |     ^
```
warning: build-tools-in-build-inputs
util-linux is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/node-packages/node-env.nix:401:7:
```
    |
401 |       buildInputs = [ tarWrapper python nodejs ]
    |       ^
```
warning: license-missing
Package is missing a license.

Near pkgs/development/node-packages/default.nix:81:7:
```
   |
81 |       meta.mainProgram = "bw";
   |       ^
```
warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.

Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:
```
   |
28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:75609:5:
```
      |
75609 |     meta = {
      |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:114223:5:
```
       |
114223 |     meta = {
       |     ^
```
warning: build-tools-in-build-inputs
libtool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/node-packages/node-env.nix:401:7:
```
    |
401 |       buildInputs = [ tarWrapper python nodejs ]
    |       ^
```
warning: build-tools-in-build-inputs
nodePackages.node-gyp-build is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/node-packages/node-env.nix:401:7:
```
    |
401 |       buildInputs = [ tarWrapper python nodejs ]
    |       ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:95995:5:
```
      |
95995 |     version = "4.2.1";
      |     ^
```
warning: missing-phase-hooks
configurePhase should probably contain runHook preConfigure and runHook postConfigure.

Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:
```
   |
28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^
```
warning: build-tools-in-build-inputs
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/node-packages/node-env.nix:401:7:
```
    |
401 |       buildInputs = [ tarWrapper python nodejs ]
    |       ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:97970:5:
```
      |
97970 |     meta = {
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:75454:5:
```
      |
75454 |     version = "5.0.0";
      |     ^
```

warning: unused-argument

Unused argument: stdenv.
Near pkgs/development/node-packages/node-packages.nix:3:46:

  |
3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
  |                                              ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:95729:5:
```
      |
95729 |     meta = {
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:113788:5:
```
       |
113788 |     version = "4.2.0";
       |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:66847:5:
```
      |
66847 |     meta = {
      |     ^
```
warning: build-tools-in-build-inputs
autoconf is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/node-packages/node-env.nix:401:7:
```
    |
401 |       buildInputs = [ tarWrapper python nodejs ]
    |       ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:89447:5:
```
      |
89447 |     version = "2.1.2";
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:70712:5:
```
      |
70712 |     version = "0.6.0";
      |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:90153:5:
```
      |
90153 |     meta = {
      |     ^
```

warning: unused-argument

Unused argument: nix-gitignore.
Near pkgs/development/node-packages/node-packages.nix:3:31:

  |
3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
  |                               ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/default.nix:81:7:
```
   |
81 |       meta.mainProgram = "bw";
   |       ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:66354:5:
```
      |
66354 |     version = "1.5.1";
      |     ^
```

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

pkgs/development/node-packages/default.nix

MatthewCroughan · 2021-07-13T18:21:28Z

I will fix the Editor Config issues in the next commit when I figure out why this won't build on aarch64

MatthewCroughan · 2021-07-13T18:48:25Z

The following error occurs on native aarch64:

config.status: creating Makefile
config.status: creating builds/Makefile
config.status: creating contrib/Makefile
config.status: creating dist-build/Makefile
config.status: creating libsodium.pc
config.status: creating libsodium-uninstalled.pc
config.status: creating msvc-scripts/Makefile
config.status: creating src/Makefile
config.status: creating src/libsodium/Makefile
config.status: creating src/libsodium/include/Makefile
config.status: creating src/libsodium/include/sodium/version.h
config.status: creating test/default/Makefile
config.status: creating test/Makefile
config.status: executing depfiles commands
config.status: error: in `/nix/store/acnfs2bmzc72qfp9gxvfk0apr781c7dm-node__at_hyperspace_slash_cli-1.5.1/lib/node_modules/@hyperspace/cli/node_modules/sodium-native/libsodium':
config.status: error: Something went wrong bootstrapping makefile fragments
    for automatic dependency tracking.  If GNU make was not used, consider
    re-running the configure script with MAKE="gmake" (or whatever is
    necessary).  You can also try re-running configure with the
    '--disable-dependency-tracking' option to at least be able to build
    the package (albeit without support for automatic dependency tracking).
See `config.log' for more details
/nix/store/acnfs2bmzc72qfp9gxvfk0apr781c7dm-node__at_hyperspace_slash_cli-1.5.1/lib/node_modules/@hyperspace/cli/node_modules/sodium-native/preinstall.js:119
    if (err) throw err
             ^

Error: ./configure exited with 1
    at ChildProcess.<anonymous> (/nix/store/acnfs2bmzc72qfp9gxvfk0apr781c7dm-node__at_hyperspace_slash_cli-1.5.1/lib/node_modules/@hyperspace/cli/node_modules/sodium-native/preinstall.js:149:>
    at ChildProcess.emit (events.js:375:28)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! sodium-native@3.2.1 install: `node-gyp-build "node preinstall.js" "node postinstall.js"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the sodium-native@3.2.1 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/nix-build-node__at_hyperspace_slash_cli-1.5.1.drv-0/.npm/_logs/2021-07-13T18_36_09_195Z-debug.log

juliosueiras · 2021-07-13T19:32:39Z

hyperspace-cli build on native aarch64(via binfmt)

MatthewCroughan · 2021-07-13T19:34:47Z

I was doing my build via nix-on-droid so it's interesting to consider that it didn't work, maybe something to do with sandboxing?

pkgs/development/node-packages/default.nix

SuperSandro2000 · 2021-07-13T21:04:51Z

pkgs/development/node-packages/default.nix

+      buildInputs = [
+        pkgs.nodePackages.node-gyp-build   
+        pkgs.nodejs
+      ];


Suggested change

buildInputs = [

pkgs.nodePackages.node-gyp-build

pkgs.nodejs

];

buildInputs = with pkgs; [

nodePackages.node-gyp-build

nodejs

];

pkgs/development/node-packages/default.nix

MatthewCroughan · 2021-07-15T18:06:23Z

I'm now re-running generate.sh which will take around 30 minutes, at which point we can merge.

Co-authored-by: Jonathan Ringer <jonringer@users.noreply.github.com> Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

tomberek · 2021-08-13T21:13:11Z

Result of nixpkgs-review pr 130063 run on x86_64-linux 1

4 packages built:

hyperspace-cli
joplin
netlify-cli
vimPlugins.coc-solargraph

ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 13, 2021

ofborg bot requested a review from midchildan July 13, 2021 02:26

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jul 13, 2021

MatthewCroughan force-pushed the hypercore-cli branch from 6891ec1 to eb27888 Compare July 13, 2021 03:09

MatthewCroughan changed the title ~~hypercore-cli: init~~ hypercore-cli: init at 1.5.1 Jul 13, 2021

MatthewCroughan changed the title ~~hypercore-cli: init at 1.5.1~~ hyperscale-cli: init at 1.5.1 Jul 13, 2021

MatthewCroughan force-pushed the hypercore-cli branch from eb27888 to e5b2028 Compare July 13, 2021 16:59

jonringer reviewed Jul 13, 2021

View reviewed changes

pkgs/development/node-packages/default.nix Outdated Show resolved Hide resolved

MatthewCroughan changed the title ~~hyperscale-cli: init at 1.5.1~~ hyperspace-cli: init at 1.5.1 Jul 13, 2021

SuperSandro2000 reviewed Jul 13, 2021

View reviewed changes

pkgs/development/node-packages/default.nix Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Jul 13, 2021

View reviewed changes

SuperSandro2000 reviewed Jul 15, 2021

View reviewed changes

pkgs/development/node-packages/default.nix Outdated Show resolved Hide resolved

ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 15, 2021

MatthewCroughan force-pushed the hypercore-cli branch from f6f440b to c163b1d Compare July 15, 2021 18:00

hyperspace-cli: init at 1.5.1

79c92e4

Co-authored-by: Jonathan Ringer <jonringer@users.noreply.github.com> Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

MatthewCroughan force-pushed the hypercore-cli branch from c163b1d to 79c92e4 Compare July 15, 2021 19:07

MatthewCroughan requested review from jonringer and SuperSandro2000 July 15, 2021 19:07

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jul 15, 2021

SuperSandro2000 merged commit 8b1ff65 into NixOS:master Jul 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hyperspace-cli: init at 1.5.1 #130063

hyperspace-cli: init at 1.5.1 #130063

MatthewCroughan commented Jul 13, 2021

r-rmcgibbo commented Jul 13, 2021 •

edited

Loading

MatthewCroughan commented Jul 13, 2021

MatthewCroughan commented Jul 13, 2021 •

edited

Loading

juliosueiras commented Jul 13, 2021

MatthewCroughan commented Jul 13, 2021

SuperSandro2000 Jul 13, 2021

MatthewCroughan commented Jul 15, 2021

tomberek commented Aug 13, 2021

hyperspace-cli: init at 1.5.1 #130063

hyperspace-cli: init at 1.5.1 #130063

Conversation

MatthewCroughan commented Jul 13, 2021

Motivation for this change

Things done

r-rmcgibbo commented Jul 13, 2021 • edited Loading

MatthewCroughan commented Jul 13, 2021

MatthewCroughan commented Jul 13, 2021 • edited Loading

juliosueiras commented Jul 13, 2021

MatthewCroughan commented Jul 13, 2021

SuperSandro2000 Jul 13, 2021

Choose a reason for hiding this comment

MatthewCroughan commented Jul 15, 2021

tomberek commented Aug 13, 2021

r-rmcgibbo commented Jul 13, 2021 •

edited

Loading

MatthewCroughan commented Jul 13, 2021 •

edited

Loading