Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add wrapQtAppsHook #127743

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Jun 22, 2021

Motivation for this change

Closes #112480

Things done

(if withQt5 then { dontWrapQtApps = true; } else {}) was there because of no wrapQtAppsHook
#108888

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Artturin
Copy link
Member Author

Artturin commented Jul 8, 2021

this will only rebuild 1 package

@SuperSandro2000 SuperSandro2000 merged commit 76ba43e into NixOS:master Jul 8, 2021
@Artturin Artturin deleted the fix-cmake-gui branch August 3, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmake-gui doesn't launch.
2 participants