nix-prefetch-git: use fetchgit's naming heuristic #12597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need the second commit? |
|
@jagajaga it belongs to a second PR, I'll remove it |
611f799 to
35fe889
Compare
|
Now part of #12603 |
This commit fixes NixOS#6651. Before this change the `nix-prefetch-git` script would use a different store name than nix's `fetchgit` function. Because of that it was not possible to use `nix-prefetch-git` as a way to pre-populate the store (for example when the user it using private git dependencies that needs access to the ssh agent)
35fe889 to
02f5a01
Compare
|
@jagajaga @copumpkin merge ? |
|
Looks good, thanks |
copumpkin
added a commit
that referenced
this pull request
Feb 13, 2016
nix-prefetch-git: use fetchgit's naming heuristic
|
To be honest, I'd like to revert this, see NixOS/nix#904 (comment) for reasoning |
|
I'm not sure about the reasoning, do you mean that we are now getting different derivations between fetchgit and nix-prefetch-git because of this change ? Would it be possible to implement nix-prefetch-git using nix-repl + fetchgit and get rid of the difference once and for all ? |
|
They use the same script (minus some wrappers). I'd like to get the same hash as for |
|
I wouldn't be upset if you reverted the commit since the goal was to achieve exactly that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #6651.
Before this change the
nix-prefetch-gitscript would use a different storename than nix's
fetchgitfunction. Because of that it was not possible touse
nix-prefetch-gitas a way to pre-populate the store (for example whenthe user it using private git dependencies that needs access to the ssh agent)