Add Plasma Mobile Gear 21.05 #125156

samueldr · 2021-06-01T02:34:16Z

Motivation for this change

#121345 is a mess to review because it is just plain too big. I'll rebase #121345 on top of this PR, which will make it hold only the Plasma Mobile shell. (The "phone GUI environment".)

Those applications are independent from actual plasma mobile.

They can seemingly be used (with caveats) on e.g. Phosh.

Only applications with a release tags are packaged.

Note that these applications launch just right on my X11 desktop with Awesome WM. No real caveats there AFAICT.

✔️ This PR is ready for reviewing.

Caveats

None of those caveats are bugs in the packaging of these applications.

(Long scary list, not actual packaging bugs)

Icons wont work as expected

{
  # Work around issues with plasma mobile apps on phosh
  #  - https://bugs.kde.org/show_bug.cgi?id=435236
  hacks.mergedIcons = {
    enable = true;

    # Helps with breeze fallback icons under gnome/phosh
    # Otherwise it might use Adwaita
    removeLegacyIcons = true;
    disabledThemes = [
      "Adwaita"
    ];

    # Options that aren't used
    #masqueradeAs = [
    #  "Adwaita" # Doesn't help really
    #];
    #iconThemes = [
    #];
  };
}

Will not start by default

By default the apps on Phosh (or GNOME too I suppose?) won't start:

Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland ro tun on Wayland anyway.

They'll try to start using xcb/X11 and crash. How rude.

The workaround is to force Wayland... Rude...

{
  environment.variables = {
    QT_QPA_PLATFORM = "wayland";
  };
}

It is unclear why those apps are willfully ignoring starting as wayland apps in Phosh (and GNOME I suppose).

CSDs in Phosh

While not really an issue, one can completely disable Qt CSDs this way:

{
  environment.variables = {
    QT_WAYLAND_DISABLE_WINDOWDECORATION = "1";
  };
}

Seems to me there is a need for some coordination between "phone environments" to properly tell when CSDs are needed and when they're not for docked/undocked modes :/.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Added a release notes entry if the change is major or breaking
Fits CONTRIBUTING.md.

Actual tests:

I ran applications on my X11 desktop and under Phosh. Apps were also ran in their previous releases under Plasma Mobile, but not this most up-to-date branch yet.

Fully tested:

alligator
calindori
kalk
kclock
koko
krecorder
ktrip
~~kweather~~ (not part of 21.05)
~~plasma-camera~~ (not part of 21.05)
plasma-phonebook

Features untested:

plasma-dialer (dialing/receiving a call... basically ofono integration)
spacebar (sms receiving/sending... basically ofono integration)

cc @NixOS/qt-kde

TODO

Use an update script for Plasma Mobile Gear

r-rmcgibbo · 2021-06-01T03:26:56Z

Result of nixpkgs-review pr 125156 at 605cb65f run on x86_64-linux 1

2 packages skipped due to time constraints:

kclock
kweather

10 packages built successfully:

alligator
calindori
kalk
kirigami-addons
krecorder
libqofono
plasma-camera
plasma-dialer
plasma-phonebook
spacebar-sms

3 suggestions:

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/tools/networking/libqofono/default.nix:28:5:
```
   |
28 |     ./0001-NixOS-Skip-tests-they-re-shock-full-of-hardcoded-FHS.patch
   |     ^
```
warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/tools/networking/libqofono/default.nix:24:5:
```
   |
24 |     (substituteAll {
   |     ^
```
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/applications/science/math/kalk/default.nix:4:3:
```
  |
4 | , fetchpatch
  |   ^
```

pkgs/applications/networking/feedreaders/alligator/default.nix

pkgs/applications/graphics/plasma-camera/default.nix

pkgs/applications/misc/kweather/default.nix

samueldr · 2021-06-06T22:42:58Z

I intend to merge this by the end of this week. (Unless someone else merges this beforehand.)

pkgs/applications/graphics/plasma-camera/default.nix

pkgs/tools/networking/libqofono/default.nix

pkgs/top-level/all-packages.nix

dotlambda · 2021-06-07T09:58:50Z

Running kclock prints

QML debugging is enabled. Only use this in a safe environment.

Is there a way to make a release build without that?

samueldr · 2021-06-07T21:08:25Z

https://invent.kde.org/plasma-mobile/kclock/-/commit/64931326ee991e9fc24f749944cdf6815c7426e3

sighs

samueldr · 2021-06-07T21:10:21Z

I believe everything @dotlambda requested has been changed.

About inclusion in pkgs/top-level/qt5-packages.nix... Really it just wasn't clear to me where things should go for a lot of this.

dotlambda · 2021-06-07T21:23:32Z

About inclusion in pkgs/top-level/qt5-packages.nix... Really it just wasn't clear to me where things should go for a lot of this.

I would say: everything that might be used with multiple versions of Qt, i.e. libraries, go in qt5-packages.nix.

samueldr · 2021-07-14T00:47:59Z

Previous force pushes:

Strictly rebases on top of nixos-unstable
Drops a conflicting alias we definitely can drop (kalk -> kalker #125555)

samueldr · 2021-09-27T20:06:59Z

Last force push to work around a bogus check barking angrily...

Mindavi · 2021-10-02T10:10:22Z

I tried this out on the pinephone (tested kclock, krecorder and kalk).

Apart from krecorder missing some icons for the buttons (I had to click on them blindly), they do build on aarch64. Krecorder somehow doesn't show recordings that I save, but it's probably not related to packaging.

Mindavi

Quickly skimmed over, LGTM

samueldr · 2021-10-02T17:22:22Z

@Mindavi just so it's clear, there's a list of caveats, and part of it has a Icons wont work as expected description. Icons missing outside of Plasma environments is a known issue, and squarely an (ignored) upstream issue.

ttuegel · 2021-10-02T20:27:33Z

pkgs/applications/plasma-mobile/fetch.sh

@@ -0,0 +1 @@
+WGET_ARGS=( http://download.kde.org/stable/plasma-mobile/21.05 -A '*.tar.xz' )


That's strange... Here's what I know: wget is acting as a (not very smart) link scraper, looking for <a> tags with filenames that match the given pattern. This has broken pretty spectacularly in the past when, for example, KDE modified their website to insert most of the page content with JavaScript. I wonder if, at some point, the page source contained links for both versions? It only seems to have 21.05 now, though.

pkgs/applications/kde/kpublictransport.nix

pkgs/applications/plasma-mobile/default.nix

The alias has been present for 40 days, the previous package was present for not more than 3 days with the `kalk` name.

Used similarly to the KDE Gear scripts: ``` $ ./maintainers/scripts/fetch-kde-qt.sh pkgs/applications/plasma-mobile/ ```

Generated with the fetch script.

Though it is empty, the package set is valid. Next changes introduce derivations for packages we maintain.

requires data that is not versioned: - https://invent.kde.org/graphics/koko#packaging Snapshotted because... Obviously that won't do with Nix.

samueldr mentioned this pull request Jun 1, 2021

Add support for Plasma Mobile #121345

Merged

10 tasks

ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jun 1, 2021

samueldr force-pushed the feature/plasma-mobile-apps-only branch from 605cb65 to 3140785 Compare June 1, 2021 04:53

dotlambda reviewed Jun 1, 2021

View reviewed changes

pkgs/applications/networking/feedreaders/alligator/default.nix Outdated Show resolved Hide resolved

pkgs/applications/graphics/plasma-camera/default.nix Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Jun 1, 2021

View reviewed changes

pkgs/applications/misc/kweather/default.nix Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Jun 1, 2021

View reviewed changes

pkgs/applications/misc/kweather/default.nix Outdated Show resolved Hide resolved

samueldr force-pushed the feature/plasma-mobile-apps-only branch 2 times, most recently from 0f36d6b to b06212c Compare June 1, 2021 21:00

dotlambda reviewed Jun 7, 2021

View reviewed changes

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved

samueldr force-pushed the feature/plasma-mobile-apps-only branch 3 times, most recently from 22bfa81 to d63ce71 Compare June 7, 2021 20:54

samueldr force-pushed the feature/plasma-mobile-apps-only branch from d63ce71 to 00caaee Compare June 7, 2021 21:09

This comment has been minimized.

Sign in to view

samueldr self-assigned this Jun 10, 2021

samueldr marked this pull request as draft June 10, 2021 18:22

samueldr removed their assignment Jun 10, 2021

samueldr force-pushed the feature/plasma-mobile-apps-only branch 2 times, most recently from 9eb31ed to a49cf97 Compare July 14, 2021 00:47

samueldr force-pushed the feature/plasma-mobile-apps-only branch from ada3cdc to aa4b9b5 Compare September 27, 2021 20:06

samueldr force-pushed the feature/plasma-mobile-apps-only branch from aa4b9b5 to 0dbe821 Compare September 29, 2021 21:15

Mindavi approved these changes Oct 2, 2021

View reviewed changes

ttuegel approved these changes Oct 2, 2021

View reviewed changes

SuperSandro2000 reviewed Oct 2, 2021

View reviewed changes

pkgs/applications/kde/kpublictransport.nix Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Oct 2, 2021

View reviewed changes

pkgs/applications/plasma-mobile/default.nix Outdated Show resolved Hide resolved

samueldr added 18 commits October 5, 2021 23:21

aliases: Drop kalk (kalker)

5dc009c

The alias has been present for 40 days, the previous package was present for not more than 3 days with the `kalk` name.

kirigami-addons: init at 21.05

af47c47

kpublictransport: init at 21.04.0

b565179

libqofono: init at 0.103

3e9044f

applications/plasma-mobile: Add fetch script

b77fcd3

Used similarly to the KDE Gear scripts: ``` $ ./maintainers/scripts/fetch-kde-qt.sh pkgs/applications/plasma-mobile/ ```

applications/plasma-mobile: Init srcs.nix

f974dc3

Generated with the fetch script.

applications/plasma-mobile: Add empty plasma-mobile package set

3f7fa2e

qt5-packages.nix: Add plasmaMobileGear

546b930

Though it is empty, the package set is valid. Next changes introduce derivations for packages we maintain.

kalk: init at 21.05

094eb89

kclock: init at 21.05

dcbe5b8

alligator: init at 21.05

7d8cb83

calindori: init at 21.05

d07a0ae

krecorder: init at 21.05

0acc854

plasma-dialer: init at 21.05

211cba4

plasma-phonebook: init at 21.05

907976e

spacebar: init at 21.05

ea73dda

koko: init at 21.05

25a433d

requires data that is not versioned: - https://invent.kde.org/graphics/koko#packaging Snapshotted because... Obviously that won't do with Nix.

ktrip: init at 21.05

8a23358

samueldr force-pushed the feature/plasma-mobile-apps-only branch from 0dbe821 to 8a23358 Compare October 6, 2021 03:21

samueldr merged commit 3128520 into NixOS:master Oct 6, 2021

samueldr deleted the feature/plasma-mobile-apps-only branch October 6, 2021 03:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Plasma Mobile Gear 21.05 #125156

Add Plasma Mobile Gear 21.05 #125156

samueldr commented Jun 1, 2021 •

edited

Loading

r-rmcgibbo commented Jun 1, 2021

samueldr commented Jun 6, 2021

dotlambda commented Jun 7, 2021

samueldr commented Jun 7, 2021

samueldr commented Jun 7, 2021

dotlambda commented Jun 7, 2021

This comment has been minimized.

samueldr commented Jul 14, 2021 •

edited

Loading

samueldr commented Sep 27, 2021

Mindavi commented Oct 2, 2021 •

edited

Loading

Mindavi left a comment

samueldr commented Oct 2, 2021

ttuegel Oct 2, 2021

		@@ -0,0 +1 @@
		WGET_ARGS=( http://download.kde.org/stable/plasma-mobile/21.05 -A '*.tar.xz' )

Add Plasma Mobile Gear 21.05 #125156

Add Plasma Mobile Gear 21.05 #125156

Conversation

samueldr commented Jun 1, 2021 • edited Loading

Motivation for this change

Caveats

Icons wont work as expected

Will not start by default

CSDs in Phosh

Things done

TODO

r-rmcgibbo commented Jun 1, 2021

samueldr commented Jun 6, 2021

dotlambda commented Jun 7, 2021

samueldr commented Jun 7, 2021

samueldr commented Jun 7, 2021

dotlambda commented Jun 7, 2021

This comment has been minimized.

samueldr commented Jul 14, 2021 • edited Loading

samueldr commented Sep 27, 2021

Mindavi commented Oct 2, 2021 • edited Loading

Mindavi left a comment

Choose a reason for hiding this comment

samueldr commented Oct 2, 2021

ttuegel Oct 2, 2021

Choose a reason for hiding this comment

samueldr commented Jun 1, 2021 •

edited

Loading

samueldr commented Jul 14, 2021 •

edited

Loading

Mindavi commented Oct 2, 2021 •

edited

Loading