-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lego: 4.2.0 -> 4.3.1 #115869
lego: 4.2.0 -> 4.3.1 #115869
Conversation
https://github.com/go-acme/lego/releases/tag/v4.3.0
Already broken on master since 2021/01/30. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Diff LGTM
- Commit LGTM
- Builds via
nix-review
on x86-64-linux
1 package built:
lego
Yeah this is already tracked in #114751. I will look into it ASAP |
lego.passthru.tests seems to be working now if you rebase it on master. LGTM |
Updated to 4.3.1 and rebased on top of master, LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Diff LGTM
- Commits LGTM
- Builds via
nix-review
on x86-64-linux
1 package built:
lego
@GrahamcOfBorg test acme |
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/go-acme/lego/releases.
meta.description for lego is: "Let's Encrypt client and ACME library written in Go"
meta.homepage for lego is: "https://go-acme.github.io/lego/"
meta.changelog for lego is: ""
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done (click to expand)
built on NixOS
Warning: a test defined in
passthru.tests
did not pass0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 4.3.0 with grep in /nix/store/0f0w8bh6f8sr4hrhljp8hl29yrm87mj8-lego-4.3.0
directory tree listing: https://gist.github.com/98a5a96e4769fdb681f799d827674bc3
du listing: https://gist.github.com/e2758fb95ad29ec7a95a073e32243918
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review
run on x86_64-linux 11 package built:
Maintainer pings
cc @aanderse @andrew-d @arianvp @emilazy @flokli @m1cr0man @kalbasit for testing.