Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lego: 4.2.0 -> 4.3.1 #115869

Merged
merged 1 commit into from
May 3, 2021
Merged

lego: 4.2.0 -> 4.3.1 #115869

merged 1 commit into from
May 3, 2021

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/go-acme/lego/releases.

meta.description for lego is: "Let's Encrypt client and ACME library written in Go"

meta.homepage for lego is: "https://go-acme.github.io/lego/"

meta.changelog for lego is: ""

Updates performed
  • Golang update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
lego
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/0f0w8bh6f8sr4hrhljp8hl29yrm87mj8-lego-4.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A lego https://github.com/r-ryantm/nixpkgs/archive/44f5cbc02486387aeed32c197266274e3fc6c7b2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/0f0w8bh6f8sr4hrhljp8hl29yrm87mj8-lego-4.3.0
ls -la /nix/store/0f0w8bh6f8sr4hrhljp8hl29yrm87mj8-lego-4.3.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • lego

Maintainer pings

cc @aanderse @andrew-d @arianvp @emilazy @flokli @m1cr0man @kalbasit for testing.

@mweinelt
Copy link
Member

mweinelt commented Mar 11, 2021

https://github.com/go-acme/lego/releases/tag/v4.3.0

Warning: a test defined in passthru.tests did not pass

Already broken on master since 2021/01/30.
https://hydra.nixos.org/build/136070382

Bisected to fccda5a
#108819

Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commit LGTM
  • Builds via nix-review on x86-64-linux
1 package built:
lego

@m1cr0man
Copy link
Contributor

https://github.com/go-acme/lego/releases/tag/v4.3.0

Warning: a test defined in passthru.tests did not pass

Already broken on master since 2021/01/30.
https://hydra.nixos.org/build/136070382

Bisected to fccda5a
#108819

Yeah this is already tracked in #114751. I will look into it ASAP

@artemist
Copy link
Member

artemist commented May 2, 2021

lego.passthru.tests seems to be working now if you rebase it on master. LGTM

@mweinelt mweinelt force-pushed the auto-update/lego branch from 44f5cbc to 7985d9e Compare May 2, 2021 17:15
@mweinelt mweinelt changed the title lego: 4.2.0 -> 4.3.0 lego: 4.2.0 -> 4.3.1 May 2, 2021
@mweinelt
Copy link
Member

mweinelt commented May 2, 2021

Updated to 4.3.1 and rebased on top of master, LGTM.

@mweinelt mweinelt added this to the 21.05 milestone May 2, 2021
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review on x86-64-linux
1 package built:
lego

@mweinelt
Copy link
Member

mweinelt commented May 3, 2021

@GrahamcOfBorg test acme

@mweinelt mweinelt merged commit 001389c into NixOS:master May 3, 2021
@r-ryantm r-ryantm deleted the auto-update/lego branch May 4, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants