Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux-pam: Optionally build with libxcrypt #114794

Merged
merged 1 commit into from
Mar 2, 2021
Merged

linux-pam: Optionally build with libxcrypt #114794

merged 1 commit into from
Mar 2, 2021

Conversation

dottedmag
Copy link
Contributor

@dottedmag dottedmag commented Mar 2, 2021 •
edited
Loading

Motivation for this change

This change enables support for new password hashing functions in PAM.

A part of #112371.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dottedmag
linux-pam: Optionally build with libxcrypt
e3dd2de 
This enables support for new password hashing functions in PAM.

A part of #112371.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 2, 2021
drewrisinger
drewrisinger approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review (no changes) & manually with withLibxcrypt ? true. /nix/store/hdn5jf56f8smb7z0w0jjwr85hw5rxyji-linux-pam-1.5.1

On a side note, this package could use a maintainer.

@SuperSandro2000
Copy link
Member

  • Builds via nix-review (no changes) & manually with withLibxcrypt ? true.

Tested using nix-build -E "with import ./. {}; pkgsCross.aarch64-multiplatform.linux-pam.override { withLibxcrypt = true; }" and builds fine.

@SuperSandro2000 SuperSandro2000 merged commit 5796220 into NixOS:master Mar 2, 2021
@dottedmag dottedmag deleted the libxcrypt-pam branch March 2, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dottedmag @SuperSandro2000 @drewrisinger