-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZERO Hydra Failures 20.09 #97479
Comments
This issue has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nixos-20-09-zero-hydra-failures/8928/1 |
It can also be useful to refer to https://hydra.nixos.org/eval/1611944, a |
Also, people can use @samueldr 's nix-review-tools to create a report which will show which packages are causing the most failures. I usually do something like:
|
It's blown up by ghc timing out. That has been occasionally happening and it should go away after some restart(s). |
@vcunat should we pass "big-parallel" for the ghc build so that it has more cores? |
Since last time this was useful to many, here's one way to build all packages which have you as maintainer:
|
On darwin the compilation would fail with the following warning: ``` clang-7: error: argument unused during compilation: '-fno-strict-overflow' [-Werror,-Wunused-command-line-argument] ``` This error happens because the `-fno-strict-overflow` is passed to the compiler. To fix this, disable the `strictoverflow` hardening feature. Also see NixOS#39687. ZHF: NixOS#97479
We cannot ping @NixOS/nixos-release-managers as required in the issue if we’re not part of the organization, is it possible to fix that? |
I know there's a more limited number of people who use nix on macOS, so I'd like to focus my efforts there, is there a way of getting a list of jobs that are succeeding on |
aarch64 GHC: that's issue #97407. We currently have a fixup in staging-next, so if it turns out well on Hydra, I planned to pick it to 20.09 as well. (other platforms won't even rebuild) |
I expect that KDE/Qt failures might be some remaining cases of combining different Qt5 versions, e.g. /cc #101411 EDIT: I haven't had time to really look into these so far.
|
Regarding the Fritzing build error, it seems I forgot to backport #98381 |
Fritzing didn't build, now it starts up OK. Picked as f5ad6d9. |
Another current state of the ZHF: Evals reportReport built at 2020-10-26 19:06:44 UTC Built for evals: i686-linux
Failure table
x86_64-linux
Failure table
aarch64-linux
Failure table
Still queued
Failure table
Problematic dependencies
Generated by eval-report |
We have our first 20.09 stable evaluation completed: https://hydra.nixos.org/build/129285763. Thus this should be closed. Fixing broken packages will always be possible throughout the lifetime of the 20.09 release. However, you may need to remove the |
This issue has been mentioned on NixOS Discourse. There might be relevant details there: |
This issue has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/20-09-release-retrospective/9851/19 |
UPDATE after initial 20.09 Release:
Fixing broken packages will always be possible throughout the lifetime of the 20.09 release. However, you may need to remove the broken = true; attr on the package. Otherwise please follow normal back-port conventions. :)
Old Post:
Jobsets:
Mission
Every time we branch off a release we stabilize the release branch.
Our goal here is to get as little as possible jobs failing on the release-20.09 jobsets.
I'd like to heighten, while it's great to focus on zero as our goal, it's essentially to
have all deliverables that worked in the previous release work here also.
How many failing jobs are there?
At the opening of this issue we have the main
x86_64-linux
jobset at 1153 failing jobs,x86_64-darwin
at >7130, andaarch64-linux
at 7573+.Previous releases first evals
19.09 had 1654 failing jobs.
20.03 had 1204 failing jobs,
20.09 had 1153 failing jobs,
So we're actually getting better at maintaining a more stable "unstable" channel.
However, our darwin story isn't as good (we need more darwin reviewers/contributors)
20.03 had 1384 failing jobs,
20.09 had >7130 failing jobs,
How to help (textual)
Select an evaluation of the release-20.09 jobset by #id
Find a failed job ❌️
Troubleshoot why it's failing and fix it
Create a Pull Request with the fix targeting master, wait for it to be merged.
Generally the job fails on master also, you can verify that on Hydra - example URL: https://hydra.nixos.org/job/nixpkgs/trunk/bash.x86_64-linux.
That means most PR's should be target the
master
branch, however, if your PR causes around 500+ rebuilds, it's preferred to targetstaging
to avoid compute and storage churn.Always reference this issue in the body of your PR:
Please ping @NixOS/nixos-release-managers on the PR.
If you're unable to because you're not a member of the NixOS org please ping
@jonringer and @worldofpeace (the same people in the team).
How to help video tutorial
@jonringer has made a video on YouTube to guide anyone through how fixing something for ZHF will look like: https://www.youtube.com/watch?v=4Zb3GpIc6vk&
New to nixpkgs?
@jonringer created some videos to help get people started with nixpkgs:
Also be sure to check out other resources at: https://github.com/nix-community/awesome-nix
Packages that don't get fixed
The remaining packages will be marked as broken before the release (on the failing platforms).
You can do this like:
These are the utility flags used to test the type of platform.
Closing
This is a great way to help NixOS, and it was some of my earliest contributions.
Let's go ✌️
✨️ @worldofpeace and @jonringer
cc @NixOS/nixpkgs-committers @NixOS/nixpkgs-maintainers
Related Issues
The text was updated successfully, but these errors were encountered: