Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix services that have TimeoutStartSec=0 #49700

Closed
nh2 opened this issue Nov 3, 2018 · 2 comments
Closed

Fix services that have TimeoutStartSec=0 #49700

nh2 opened this issue Nov 3, 2018 · 2 comments
Labels
0.kind: bug Something is broken

Comments

@nh2
Copy link
Contributor

nh2 commented Nov 3, 2018

Issue description

TimeoutStartSec = 0 is likely wrong, it doesn't make much sense to expect that the service starts in 0 time. Perhaps infinite was meant?

Units we know we should investigate and fix:
@nh2 nh2 added the 0.kind: bug Something is broken label Nov 3, 2018
nh2 referenced this issue Nov 3, 2018
@wkennington
nixos/consul: Fix timeout bugs and json formatting
9ce0c1c
nh2 referenced this issue Nov 3, 2018
@cstrahan
osquery: init at 2.5.2
53426f6
@nh2 nh2 mentioned this issue Nov 3, 2018
Open
@cyounkins
Copy link
Contributor

Previous versions of systemd used 0 to disable the timeout logic.

Ref: https://github.com/systemd/systemd/blob/4f7dc24f8bbb3c312a46dc8d8f25658d02d47bfe/NEWS#L2798

The correct new value is infinity

@cyounkins cyounkins mentioned this issue Nov 23, 2018
Merged
10 tasks
cyounkins added a commit to cyounkins/nixpkgs that referenced this issue Nov 24, 2018
@cyounkins
systemd timeout arguments to use infinity instead of 0
76d412a 
Fixes NixOS#49700
zimbatm pushed a commit that referenced this issue Nov 25, 2018
@cyounkins @zimbatm
treewide: systemd timeout arguments to use infinity instead of 0 (#50934
eff461c 
)

Fixes #49700
@nh2
Copy link
Contributor Author

nh2 commented Nov 25, 2018

Thanks @cyounkins!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug Something is broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cyounkins @nh2