Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frigate: enables nginx.recommendedProxySettings by default #320512

Closed
nagisa opened this issue Jun 17, 2024 · 1 comment · Fixed by #357717
Closed

frigate: enables nginx.recommendedProxySettings by default #320512

nagisa opened this issue Jun 17, 2024 · 1 comment · Fixed by #357717
Labels
0.kind: bug Something is broken

Comments

@nagisa
Copy link
Contributor

nagisa commented Jun 17, 2024

Describe the bug

When I enabled frigate in my system that otherwise also uses nginx, I was surprised to find that some of the nginx servers I had suddenly were broken (and returning 400s.) Namely headscale.

I had to go to those specific nginx servers and set services.nginx.virtualHosts.headscale.locations."/".recommendedProxySettings = false; in order to keep things working.

I think frigate should not be enabling this option globally and instead set it for each individual location it specifies in order to not interfere with other virtualHosts.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Specify a virtualHost manually, build config, check generated nginx conf to see absence of recommendedProxySettings include;
  2. Enable frigate, rebuild;
  3. nginx config now contains recommended proxy settings includes for all server blocks/locations.

Expected behavior

Enabling frigate does not affect other nginx servers in any way.

Screenshots

N/A

Additional context

N/A

Notify maintainers

no meta key in the frigate module.

Metadata

  • system: "x86_64-linux"
  • host os: Linux 6.8.6-zen1, NixOS, 24.05 (Uakari), 24.05.20240519.6c0b7a9
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.18.2
  • nixpkgs: /run/current-system/nixpkgs

Add a 👍 reaction to issues you find important.

@nagisa nagisa added the 0.kind: bug Something is broken label Jun 17, 2024
@nagisa
Copy link
Contributor Author

nagisa commented Jun 17, 2024

My jellyfin setup also appears to be affected by this.

@GrumpyMeow GrumpyMeow mentioned this issue Aug 6, 2024
13 tasks
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Nov 21, 2024
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Nov 21, 2024
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Nov 21, 2024
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Nov 21, 2024
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Nov 21, 2024
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Nov 21, 2024
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Nov 21, 2024
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Nov 21, 2024
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Nov 21, 2024
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Nov 22, 2024
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Nov 22, 2024
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Nov 22, 2024
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Nov 22, 2024
mweinelt added a commit to mweinelt/nixpkgs that referenced this issue Nov 22, 2024
github-actions bot pushed a commit that referenced this issue Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant