Race condition between systemd-binfmt and systemd-tmpfiles when using boot.binfmt

[arianvp]

Describe the bug

This bug was introduced in #263203

Before the folder /run/binfmt would be populated before systemd even runs (in an activation script).
Now it seems systemd-tmpfiles and systemd-binfmt are running in parallel. Hence a race condition is occurring.
Sometimes this works. Sometimes it doesn't.

Steps To Reproduce

Reboot often and it will complain /run/binfmt doesn't exist every once and a while

Mar 12 17:58:59 utm systemd-binfmt[604]: /etc/binfmt.d/nixos.conf:1: Failed to add binary format 'rosetta': No such file or directory
Mar 12 17:58:59 utm systemd[1]: systemd-binfmt.service: Main process exited, code=exited, status=1/FAILURE
Mar 12 17:58:59 utm systemd[1]: systemd-binfmt.service: Failed with result 'exit-code'.
Mar 12 17:58:59 utm systemd[1]: Failed to start Set Up Additional Binary Formats.

Expected behavior

/run/binfmt is created before systemd-binfmt is started

I expect that we can perhaps fix this with a:

systemd.services.systemd-binfmt.after = [ "systemd-tmpfiles-setup.service" ];

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

Notify maintainers

@nikstur

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

---

Add a 👍 reaction to issues you find important.