-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Luarocks package versions override Vim Plugin versions #188302
Labels
Comments
Ahh, didn't realize there was already a ticket! As for #188090, I clicked the tarball link and it downloaded. Maybe the archive site is back? |
Attempting to update all the lua packages now in #185723 |
bookest
added a commit
to bookest/nix-config
that referenced
this issue
Sep 3, 2022
This update broke a bunch of neovim nightly related things that took way to long to figure out. I ended up needing to make a couple of changes to my config to get things working again: - Disable gitsigns - Remove vim-polyglot Gitsigns is broken due to an old version of the plugin being pulled in via the nix luaRocks package versions in nixpkgs. This was originally identified on NixOS/nixpkgs#188302, which tracked it back to NixOS/nixpkgs#185723, which I'm now following so I'll know when to try re-enabling gitsigns. This is a bit of a bummer. vim-polyglot just started failing the nix build while generating the remote plugin manifest. I don't actually care that much about vim-polyglot, so I just ripped it out and added the few language plugins I actually care about directly. I'm sure I missed something, but it's easy to add new languages. IIRC there were some things I needed to work around with vim-polyglot anyways (like vim-go not loading everything), so no big loss here. Overall way too exciting of a `niv update`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Not sure if this is intended behavior or not, but while trying to track down a bug in gitsigns-nvim plugin, I realized that the version of the plugin I had installed in neovim was not actually the version specified in the the vim plugins generated file.
A recent neovim change started producing an error when using the gitsigns plugin. The author recently put in a fix, and the version specified in the vim plugin file includes the fix for this error:
nixpkgs/pkgs/applications/editors/vim/plugins/generated.nix
Line 3163 in 963d27a
However, I was still running into the error and had reported it to the plugin author. After some back and forth, and a bunch of digging, I realized that the version that was actually installed in my neovim was a much earlier version, and thats when I discovered that this plugin (and presumably Plenary as well), gets overridden with the version in Luarocks here:
nixpkgs/pkgs/development/lua-modules/generated-packages.nix
Line 515 in 03428db
Is this intended behavior? If so, is there a way to make it more obvious to end users that these plugins in the vim generated plugins file is effectively ignored?
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
I possibly expect it to use the gitsigns version specified in the vim plugin generated file.
Notify maintainers
@Scoder12 @teto
Metadata
Please run
nix-shell -p nix-info --run "nix-info -m"
and paste the result.The text was updated successfully, but these errors were encountered: