Skip to content

Commit

Permalink
python3Packages.torch: switch to apple-sdk_13
Browse files Browse the repository at this point in the history
Switch to apple-sdk_13 on Darwin. This enables the use of MPS (Metal
Performance Shaders) on macOS.

Signed-off-by: Mika Tammi <mikatammi@gmail.com>
  • Loading branch information
mikatammi committed Nov 8, 2024
1 parent 1610bc1 commit 61220d7
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions pkgs/development/python-modules/torch/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
removeReferencesTo,

# Build inputs
darwin,
apple-sdk_13,
numactl,

# dependencies
Expand Down Expand Up @@ -364,6 +364,9 @@ buildPythonPackage rec {
# NB technical debt: building without NNPACK as workaround for missing `six`
USE_NNPACK = 0;

# Explicitly enable MPS for Darwin
USE_MPS = setBool stdenv.hostPlatform.isDarwin;

cmakeFlags =
[
# (lib.cmakeBool "CMAKE_FIND_DEBUG_MODE" true)
Expand Down Expand Up @@ -519,9 +522,7 @@ buildPythonPackage rec {
++ lib.optionals (cudaSupport || rocmSupport) [ effectiveMagma ]
++ lib.optionals stdenv.hostPlatform.isLinux [ numactl ]
++ lib.optionals stdenv.hostPlatform.isDarwin [
darwin.apple_sdk.frameworks.Accelerate
darwin.apple_sdk.frameworks.CoreServices
darwin.libobjc
apple-sdk_13
]
++ lib.optionals tritonSupport [ _tritonEffective ]
++ lib.optionals MPISupport [ mpi ]
Expand Down

0 comments on commit 61220d7

Please sign in to comment.