Skip to content

Commit

Permalink
nodejs: fix flaky test
Browse files Browse the repository at this point in the history
  • Loading branch information
FliegendeWurst committed Nov 26, 2024
1 parent 4685474 commit 4a3d094
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion pkgs/development/web/nodejs/nodejs.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
, gnupg
, darwin
, installShellFiles
, fetchpatch
}:

{ enableNpm ? true, version, sha256, patches ? [] } @args:
Expand Down Expand Up @@ -249,7 +250,13 @@ let

pos = builtins.unsafeGetAttrPos "version" args;

inherit patches;
patches = patches ++ [
# fixes test failure
(fetchpatch {
url = "https://github.com/nodejs/node/commit/b6fe731c55eb4cb9d14042a23e5002ed39b7c8b7.patch";
hash = "sha256-y45G9Vc58Nh0I+kSS3iRnoZe7se55rk3PVMpgZgPY+U=";
})
];

__darwinAllowLocalNetworking = true; # for tests

Expand Down Expand Up @@ -299,6 +306,7 @@ let
"FLAKY_TESTS=skip"
# Skip some tests that are not passing in this context
"CI_SKIP_TESTS=${lib.concatStringsSep "," ([
# Tests don't work in sandbox.
"test-child-process-exec-env"
"test-child-process-uid-gid"
"test-fs-write-stream-eagain"
Expand Down

0 comments on commit 4a3d094

Please sign in to comment.