Skip to content

Commit

Permalink
workflows/eval: remove non-required "needs: attrs"
Browse files Browse the repository at this point in the history
The eval-aliases job is independent of attrs already and the tag job
doesn't need it to checkout the base branch.
  • Loading branch information
wolfgangwalther committed Jan 9, 2025
1 parent 88afad8 commit 27d5f29
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/eval.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
eval-aliases:
name: Eval nixpkgs with aliases enabled
runs-on: ubuntu-24.04
needs: [ attrs, get-merge-commit ]
needs: [ get-merge-commit ]
steps:
- name: Check out the PR at the test merge commit
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand Down Expand Up @@ -226,7 +226,7 @@ jobs:
tag:
name: Tag
runs-on: ubuntu-24.04
needs: [ attrs, process ]
needs: [ process ]
if: needs.process.outputs.baseRunId
permissions:
pull-requests: write
Expand All @@ -249,12 +249,12 @@ jobs:
- name: Install Nix
uses: cachix/install-nix-action@08dcb3a5e62fa31e2da3d490afc4176ef55ecd72 # v30

# Important: This workflow job runs with extra permissions,
# so we need to make sure to not run untrusted code from PRs
# Important: Because we use pull_request_target, this checks out the base branch of the PR, not the PR head.
# This is intentional, because this job runs with extra permissions,
# so we need to make sure to not run untrusted code from PRs.
- name: Check out Nixpkgs at the base commit
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
ref: ${{ needs.attrs.outputs.baseSha }}
path: base
sparse-checkout: ci

Expand Down

0 comments on commit 27d5f29

Please sign in to comment.