dell: add XPS 9570 #134
dell: add XPS 9570 #134
Conversation
|
|
||
| # TODO: boot loader | ||
| boot.loader.systemd-boot.enable = lib.mkDefault true; | ||
| boot.loader.efi.canTouchEfiVariables = lib.mkDefault true; |
There was a problem hiding this comment.
Do not enable this by default. It should be only used during installation.
Enabling it by default will wear out the NVRAM since it would write new entries on every nixos-rebuild switch.
| ]; | ||
|
|
||
| # TODO: boot loader | ||
| boot.loader.systemd-boot.enable = lib.mkDefault true; |
There was a problem hiding this comment.
Is there anything inherently that would require systemd-boot over grub? If not than we should leave this up to the user to decide.
| boot.loader.systemd-boot.enable = lib.mkDefault true; | ||
| boot.loader.efi.canTouchEfiVariables = lib.mkDefault true; | ||
|
|
||
| nix.buildCores = lib.mkDefault 12; |
There was a problem hiding this comment.
Maybe we should make this the default in NixOS:
nix.buildCores = lib.mkDefault 0;
This sets cores equal to the number of hardware threads in a system.
| { | ||
| imports = [ | ||
| ../../../common/cpu/intel | ||
| ../../../common/pc/laptop |
There was a problem hiding this comment.
If all models come with at least an ssd, we could also enable:
../../common/pc/laptop/ssd
|
Please also link your profile in the README. |
|
ping? |
See there links for details: NixOS#134 (review) NixOS#134 (comment)
|
Closed due to lack of responsiveness. If everyone else wants to add this feel free to make a new pr. |
This is my current laptop that I now have in a good enough place that I'd like to share. Most of it is taken from the Arch Wiki here:
https://wiki.archlinux.org/index.php/Dell_XPS_15_9570
Note that for reasonable performance, you really do need to use the NVIDIA proprietary drivers. I won't enable it by default, but will leave the snippet I'm using in.