Print worktree path instead of store path #5625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for flake errors Closes NixOS#5425
thufschmitt
suggested changes
Nov 22, 2021
There was a problem hiding this comment.
A couple of small comments, but looks good otherwise 👍
Note that this doesn’t cover the full scope of #5425 because it only works for nix build, and not for other commands like nix eval.
(I’d be nice to have a more unique entrypoint to the evaluator, but that’s definitely out-of scope here)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-22/16251/1 |
|
Ping :) |
|
Does "lazy trees" obviate this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for flake errors
Closes #5425