-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common short version for help of CLI #509
Conversation
not sure if it's a good idea to apply |
I think it’s fine. The commits are atomic, and atomic PRs is something that is neither achievable nor even desirable. Though I wonder why these changes occur in the first place – some linting dependency that we didn’t pin hard enough? New Python version? |
I think we should manually cherry-pick a0ce779 instead of merging. |
I’m really confused now. Why can’t we start a CI run for this PR? And why did |
weird, I would also expect that the CI should run this.... pynitrokey/.github/workflows/ci.yaml Line 6 in 600527e
but, ok let's only include the first commit, @anotherbridge can you be so kind and remove the |
For first-time contributors, CI runs need to be approved. I did that recently, but I don’t remember if it was for this PR. Anyway, either the CI run should show up, or the option to approve and trigger it. |
e242c6b
to
a0ce779
Compare
@daringer @robin-nitrokey @sosthene-nitrokey I removed the commit that includes the |
2ed8c16
to
bd61327
Compare
Rebased and merged. Thank you! |
Added a short version to call the help, i.e. now the help of a functionality is available by calling
--help
and-h
.Changes
nitropy
command.Checklist
make check
make fix
Test Environment and Execution
v1.6.0-test.20231218