Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIV: use se050 backend and trussed-auth for key wrapping #534

Merged
merged 4 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,13 @@
- brainpoolp512r1
- admin-app: Add command to list all supported config fields ([admin-app#28][])
- admin-app: Add `opcard.disabled` configuration option to disable OpenPGP ([#539][])
- piv: Use SE050 and encrypt data on external flash ([#534][])

[admin-app#28]: https://github.com/Nitrokey/admin-app/issues/28
[fido-authenticator#38]: https://github.com/Nitrokey/fido-authenticator/issues/38
[piv-authenticator#38]: https://github.com/Nitrokey/piv-authenticator/issues/38
[#524]: https://github.com/Nitrokey/nitrokey-3-firmware/pull/524
[#534]: https://github.com/Nitrokey/nitrokey-3-firmware/pull/534
[#539]: https://github.com/Nitrokey/nitrokey-3-firmware/pull/539

## v1.7.2 (2024-06-11)
Expand Down
34 changes: 28 additions & 6 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,19 @@ p256-cortex-m4 = { git = "https://github.com/ycrypto/p256-cortex-m4.git", rev =
secrets-app = { git = "https://github.com/Nitrokey/trussed-secrets-app", tag = "v0.13.0" }
webcrypt = { git = "https://github.com/nitrokey/nitrokey-websmartcard-rust", tag = "v0.8.0-rc9" }
opcard = { git = "https://github.com/Nitrokey/opcard-rs", tag = "v1.5.0" }
piv-authenticator = { git = "https://github.com/Nitrokey/piv-authenticator.git", tag = "v0.3.7" }
piv-authenticator = { git = "https://github.com/Nitrokey/piv-authenticator.git", tag = "v0.3.8" }
trussed-fs-info = { git = "https://github.com/trussed-dev/trussed-staging.git", tag = "fs-info-v0.1.0" }
trussed-chunked = { git = "https://github.com/trussed-dev/trussed-staging.git", tag = "chunked-v0.1.0" }
trussed-manage = { git = "https://github.com/trussed-dev/trussed-staging.git", tag = "manage-v0.1.0" }
trussed-wrap-key-to-file = { git = "https://github.com/trussed-dev/trussed-staging.git", tag = "wrap-key-to-file-v0.1.0" }
trussed-staging = { git = "https://github.com/trussed-dev/trussed-staging.git", tag = "v0.3.1" }
trussed-staging = { git = "https://github.com/trussed-dev/trussed-staging.git", tag = "v0.3.2" }
trussed-hpke = { git = "https://github.com/trussed-dev/trussed-staging.git", tag = "hpke-v0.1.0" }
trussed-auth = { git = "https://github.com/trussed-dev/trussed-auth", rev = "947ffe6cff426ccbbbb2d0f689437f427665919e" }
trussed-hkdf = { git = "https://github.com/trussed-dev/trussed-staging.git", tag = "hkdf-v0.2.0" }
trussed-rsa-alloc = { git = "https://github.com/trussed-dev/trussed-rsa-backend.git", tag = "v0.2.1" }
trussed-usbip = { git = "https://github.com/Nitrokey/pc-usbip-runner.git", tag = "v0.0.1-nitrokey.4" }
trussed-se050-manage = { git = "https://github.com/Nitrokey/trussed-se050-backend.git", tag = "se050-manage-v0.1.0" }
trussed-se050-backend = { git = "https://github.com/Nitrokey/trussed-se050-backend.git", tag ="v0.3.5" }
trussed-se050-backend = { git = "https://github.com/Nitrokey/trussed-se050-backend.git", tag = "v0.3.6" }

[profile.release]
codegen-units = 1
Expand Down
12 changes: 7 additions & 5 deletions components/apps/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ littlefs2 = "0.4"
# Backends
trussed-auth = { version = "0.3.0", optional = true }
trussed-rsa-alloc = { version = "0.2.0", optional = true }
trussed-se050-backend = { version = "0.3.0", optional = true }
trussed-staging = { version = "0.3.0", features = ["wrap-key-to-file", "chunked", "hkdf", "manage", "fs-info"] }
trussed-se050-backend = { version = "0.3.6", optional = true }
trussed-staging = { version = "0.3.2", features = ["wrap-key-to-file", "chunked", "hkdf", "manage", "fs-info"] }

# Extensions
trussed-chunked = "0.1.0"
Expand All @@ -33,6 +33,7 @@ trussed-manage = "0.1.0"
trussed-se050-manage = { version = "0.1.0", optional = true }
trussed-wrap-key-to-file = "0.1.0"
trussed-fs-info = "0.1.0"
trussed-hpke = "0.1.0"

# apps
admin-app = "0.1.0"
Expand All @@ -41,7 +42,7 @@ ndef-app = { path = "../ndef-app", optional = true }
webcrypt = { version = "0.8.0", optional = true }
secrets-app = { version = "0.13.0", features = ["apdu-dispatch", "ctaphid"], optional = true }
opcard = { version = "1.4.0", features = ["apdu-dispatch", "delog", "rsa2048-gen", "rsa4096", "admin-app"], optional = true }
piv-authenticator = { version = "0.3.4", features = ["apdu-dispatch", "delog", "rsa"], optional = true }
piv-authenticator = { version = "0.3.8", features = ["apdu-dispatch", "delog", "rsa"], optional = true }
provisioner-app = { path = "../provisioner-app", optional = true }

[dev-dependencies]
Expand All @@ -57,7 +58,7 @@ hex = "0.4"

# nk3
nk3 = ["fido-authenticator", "ndef-app", "secrets-app", "opcard", "factory-reset", "trussed/clients-4"]
nk3-test = ["nk3", "piv-authenticator", "webcrypt", "trussed/clients-6"]
nk3-test = ["nk3", "piv-authenticator", "trussed/clients-5"]
nk3-provisioner = ["nk3", "provisioner-app", "trussed/clients-5"]

# nkpk
Expand All @@ -75,10 +76,11 @@ se050 = ["dep:se05x", "trussed-se050-backend", "trussed-se050-manage", "admin-ap
# backends
backend-auth = ["trussed-auth"]
backend-rsa = ["trussed-rsa-alloc"]
backend-software-hpke = ["trussed-staging/hpke"]

log-all = ["admin-app/log-all", "fido-authenticator?/log-all", "secrets-app?/log-all", "webcrypt?/log-all", "opcard?/log-all", "provisioner-app?/log-all"]

trussed-usbip-ccid = ["trussed-usbip/ccid"]
trussed-usbip-ccid = ["trussed-usbip/ccid", "backend-software-hpke"]

factory-reset = ["admin-app/factory-reset"]

Expand Down
36 changes: 36 additions & 0 deletions components/apps/src/dispatch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ use webcrypt::hmacsha256p256::{
HmacSha256P256Extension,
};

#[cfg(feature = "piv-authenticator")]
use trussed_hpke::HpkeExtension;

pub struct Dispatch<T = (), D = ()> {
#[cfg(feature = "backend-auth")]
auth: AuthBackend,
Expand Down Expand Up @@ -119,6 +122,10 @@ const NAMESPACE: trussed_se050_backend::namespacing::Namespace = {
client: path!("opcard"),
value: NamespaceValue::Client2,
},
NamespaceItem {
client: path!("piv"),
value: NamespaceValue::Client3,
},
])
};

Expand Down Expand Up @@ -316,6 +323,14 @@ impl<T: Twi, D: Delay> ExtensionDispatch for Dispatch<T, D> {
resources,
)
}
#[cfg(feature = "backend-software-hpke")]
Extension::Hpke => ExtensionImpl::<HpkeExtension>::extension_request_serialized(
&mut self.staging,
&mut ctx.core,
&mut ctx.backends.staging,
request,
resources,
),
#[allow(unreachable_patterns)]
_ => Err(TrussedError::RequestNotAvailable),
},
Expand Down Expand Up @@ -350,6 +365,14 @@ impl<T: Twi, D: Delay> ExtensionDispatch for Dispatch<T, D> {
resources,
)
}
#[cfg(feature = "piv-authenticator")]
Extension::Hpke => ExtensionImpl::<HpkeExtension>::extension_request_serialized(
self.se050.as_mut().ok_or(TrussedError::GeneralError)?,
&mut ctx.core,
&mut ctx.backends.se050,
request,
resources,
),
_ => Err(TrussedError::RequestNotAvailable),
},
#[cfg(feature = "se050")]
Expand Down Expand Up @@ -410,6 +433,8 @@ pub enum Extension {
HmacSha256P256,
#[cfg(feature = "se050")]
Se050Manage,
#[cfg(feature = "piv-authenticator")]
Hpke,
}

impl From<Extension> for u8 {
Expand All @@ -426,6 +451,8 @@ impl From<Extension> for u8 {
Extension::Se050Manage => 5,
Extension::Hkdf => 6,
Extension::FsInfo => 7,
#[cfg(feature = "piv-authenticator")]
Extension::Hpke => 8,
}
}
}
Expand All @@ -446,6 +473,8 @@ impl TryFrom<u8> for Extension {
5 => Ok(Extension::Se050Manage),
6 => Ok(Extension::Hkdf),
7 => Ok(Extension::FsInfo),
#[cfg(feature = "piv-authenticator")]
8 => Ok(Extension::Hpke),
_ => Err(TrussedError::InternalError),
}
}
Expand Down Expand Up @@ -502,6 +531,13 @@ impl<T: Twi, D: Delay> ExtensionId<FsInfoExtension> for Dispatch<T, D> {
const ID: Self::Id = Self::Id::FsInfo;
}

#[cfg(feature = "piv-authenticator")]
impl<T: Twi, D: Delay> ExtensionId<HpkeExtension> for Dispatch<T, D> {
type Id = Extension;

const ID: Self::Id = Self::Id::Hpke;
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down
4 changes: 2 additions & 2 deletions components/apps/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1136,8 +1136,8 @@ impl<R: Runner> App<R> for PivApp<R> {
}
fn backends(runner: &R, _: &()) -> &'static [BackendId<Backend>] {
const BACKENDS_PIV: &[BackendId<Backend>] = &[
BackendId::Custom(Backend::SoftwareRsa),
BackendId::Custom(Backend::Auth),
#[cfg(feature = "se050")]
BackendId::Custom(Backend::Se050),
BackendId::Custom(Backend::Staging),
BackendId::Core,
];
Expand Down