Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for p521 and brainpool512 #524

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Add support for p521 and brainpool512 #524

merged 2 commits into from
Aug 13, 2024

Conversation

sosthene-nitrokey
Copy link
Collaborator

@sosthene-nitrokey sosthene-nitrokey commented Aug 12, 2024 •
edited
Loading

@nitrokey-ci
Copy link
Collaborator

No significant changes.

Insignifcant changes
metric value change
binary-size-nk3am 1,439,716 🔴 +13,365 (+0.94%)
binary-size-nk3am-test 2,047,493 🔴 +15,525 (+0.76%)
binary-size-nk3xn 516,404 🔴 +4,848 (+0.95%)
binary-size-nk3xn-test 590,424 🔴 +4,784 (+0.82%)
binary-size-nkpk 746,350 ⚪ +0 (+0.00%)

robin-nitrokey
robin-nitrokey approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry? Otherwise LGTM.

@sosthene-nitrokey
Copy link
Collaborator Author

I updated the changelog. Merging and releasing the test release once CI passes.

robin-nitrokey
robin-nitrokey reviewed Aug 13, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sosthene-nitrokey sosthene-nitrokey merged commit 553fff1 into main Aug 13, 2024
9 checks passed
@sosthene-nitrokey sosthene-nitrokey deleted the p521-brainpool512 branch August 13, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-nitrokey robin-nitrokey robin-nitrokey approved these changes

@daringer daringer Awaiting requested review from daringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sosthene-nitrokey @nitrokey-ci @robin-nitrokey